chore: fix potential state corruption in UnmarshalJSON #10705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Triage note:
|
This change is necessary to maintain correct Go syntax and prevent potential compilation issues. |
|
Is there anyplace that the error is handled? I do not see this code used anywhere. If it is unused, then I would rather just remove it. |
|
Thank you for the contribution. Decided to go with #10708 instead. |
|
LOL.I created a pull request earlier... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue where
tcould be modified even iftime.Parsefailed. This could lead to unexpected behavior when handling invalid timestamps.The fix ensures that
tis only updated after a successful parse.