feat: add block based read timeout #155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Triage note:
- this is waiting for results of staging A/B testing results.
- we also may want to apply higher level timeout in gateway: ability to set response write timeout boxo#679, which would also cover this case?
| @@ -21,6 +21,8 @@ import ( | |||
| "github.com/libp2p/go-libp2p/core/routing" | |||
| ) | |||
|
|
|||
| const perBlockTimeout = time.Second * 10 | |||
There was a problem hiding this comment.
Could we bump this to 15s to match implicit defaults from https://github.com/libp2p/go-libp2p/releases/tag/v0.36.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to do some testing on this before merging, but my suspicion is that continuing to spend resources looking for a block once it's taken more than X time is likely a waste of resources.
This timeout is larger than I'd want since I think there should be a separate one for the first block lookup per query/session as that's likely to be the largest delay. However, this can potentially wait until we have context-based sessions since that will make this kind of plumbing easier.