Add lookup_self_v6
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing in v6 env lookup result: IpDetails { ip: "2a01:4f9:c010:a3ff::1", hostname: None, city: "Helsinki", region: "Uusimaa", country: "FI", country_name: Some("Finland"), is_eu: Some(true), country_flag: Some(CountryFlag { emoji: "🇫🇮", unicode: "U+1F1EB U+1F1EE" }), country_flag_url: Some("https://cdn.ipinfo.io/static/images/countries-flags/FI.svg"), country_currency: Some(CountryCurrency { code: "EUR", symbol: "€" }), continent: Some(Continent { code: "EU", name: "Europe" }), loc: "60.1695,24.9354", org: Some("AS24940 Hetzner Online GmbH"), postal: Some("00100"), timezone: Some("Europe/Helsinki"), asn: Some(AsnDetails { asn: "AS24940", name: "Hetzner Online GmbH", domain: "hetzner.de", route: "2a01:4f9::/32", asn_type: "hosting" }), company: Some(CompanyDetails { name: "Hetzner Online GmbH", domain: "hetzner.com", company_type: "hosting" }), carrier: None, privacy: Some(PrivacyDetails { vpn: false, proxy: false, tor: false, relay: false, hosting: true, service: "" }), abuse: Some(AbuseDetails { address: "Hetzner Online GmbH, Industriestrasse 25, D-91710 Gunzenhausen, Germany", country: "DE", email: "[email protected]", name: "Hetzner Online GmbH - Contact Role", network: "2a01:4f9:c010::/48", phone: "+49 9831 505-0" }), domains: Some(DomainsDetails { ip: None, total: 0, domains: [] }), bogon: None, extra: {} } |
|
I think I incorrectly concluded here that we are allowing client level configurability in our Go SDK; doesn't seem to be the case after a closer look. So going with the suggestion here to just remove input parameter and rename. @UmanShahzad |
Alextopher
reviewed
Jan 22, 2024
src/ipinfo.rs
Outdated
| self._lookup(ip, BASE_URL).await | ||
| } | ||
|
|
||
| // Lookup your own v6 IP |
There was a problem hiding this comment.
Can this be made into a doc comment? With sufficient explanation of purpose and limitations.
|
cc @Alextopher |
talhahwahla
requested review from
Alextopher and
UmanShahzad
and removed request for
Alextopher
UmanShahzad
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.