-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: publish as esm-only #80
Conversation
Following on from the conversation in ipld/ipld#224 this converts this repo to use the latest aegir with Unified CI. 1. Remove all build related dev deps apart from `aegir` 1. Run the `npx aegir check-project` command to update project config 1. Remove non-Unified-CI github actions 1. Update imports to import from `src/index.js` instead of `@ipld/dag-pb` 1. Rename `test/*.js` to `test/*.spec.js` so aegir can find them 1. Update `tsconfig.json` to extend config from `aegir` 1. Remove `"main"` and other unused fields from `package.json` 1. Use `chai` from `aegir` pre-configured with plugins we use 1. Fixes everything the linter complains about This will need a follow up PR to `protocol/.github` to add this repo to the Unified CI [config file](https://github.com/protocol/.github/blob/master/configs/js.json) so it'll get automated config updates in the future. Apologies that this PR is so noisy, most of it is from the `check-project` command
}, | ||
"keywords": [ | ||
"ipfs", | ||
"ipld", | ||
"multiformats" | ||
], | ||
"author": "Rod <[email protected]> (http://r.va.gg/)", | ||
"license": "(Apache-2.0 AND MIT)", | ||
"engines": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these don't happen to be kept updated by unified-ci do they? it concerns me that we're introducing more fields that need manual attention to keep current
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a similar concern - they are defined here and kept up to date by the aegir check-project
command.
Long(ish) term I was hoping for a aegir check-project -y
type thing we could run as part of unified CI to automate PRs for that too, I wanted to get a view on how much custom config we have across the estate first though - turns out not much so that sounds doable at some point. I think the biggest thing is the divergence in readme styles but I'm sure there's a middle ground somewhere.
To roll the multiformats upgrade in here this will need: |
## [9.0.0](v8.0.11...v9.0.0) (2022-10-19) ### ⚠ BREAKING CHANGES * publish as esm-only (#80) ### Features * publish as esm-only ([#80](#80)) ([131ea8e](131ea8e)) ### Trivial Changes * **no-release:** bump actions/setup-node from 3.4.1 to 3.5.0 ([#76](#76)) ([30578b4](30578b4)) * **no-release:** bump actions/setup-node from 3.5.0 to 3.5.1 ([#79](#79)) ([a59b710](a59b710)) * **no-release:** bump ipld-garbage from 4.0.10 to 5.0.0 ([#72](#72)) ([6e428e1](6e428e1)) * update project config ([cf08c02](cf08c02))
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Following on from the conversation in ipld/ipld#224 this converts this repo to use the latest aegir with Unified CI.
aegir
npx aegir check-project
command to update project configtest/*.js
totest/*.spec.js
so aegir can find themtsconfig.json
to extend config fromaegir
"main"
and other unused fields frompackage.json
chai
fromaegir
pre-configured with plugins we useThis will need a follow up PR to
protocol/.github
to add this repo to the Unified CI config file so it'll get automated config updates in the future.Apologies that this PR is so noisy, most of it is from the
check-project
command