Skip to content

Commit

Permalink
pkp#8887 Adapt hook signature
Browse files Browse the repository at this point in the history
  • Loading branch information
Vitaliy-1 authored and ipula committed Dec 4, 2023
1 parent a67e500 commit 5679008
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions classes/submission/reviewAssignment/Repository.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ public function getSchemaMap(): maps\Schema
* Perform validation checks on data used to add or edit a review assignment.
*
* @param array $props A key/value array with the new data to validate
* @param array $allowedLocales The context's supported locales
* @param string $primaryLocale The context's primary locale
*
* @return array A key/value array with validation errors. Empty if no errors
*
* @hook ReviewAssignment::validate [&$errors, $object, $props, $allowedLocales, $primaryLocale]
*/
public function validate(?ReviewAssignment $object, array $props, Context $context): array
{
Expand All @@ -118,7 +118,7 @@ public function validate(?ReviewAssignment $object, array $props, Context $conte

// Check if submission exists
if (isset($props['submissionId'])) {
$validator->after(function($validator) use ($props) {
$validator->after(function ($validator) use ($props) {
if (!$validator->errors()->get('submissionId')) {
$submission = Repo::submission()->get($props['submissionId']);
if (!$submission) {
Expand All @@ -130,7 +130,7 @@ public function validate(?ReviewAssignment $object, array $props, Context $conte

// Check if reviewer exists
if (isset($props['reviewerId'])) {
$validator->after(function($validator) use ($props, $context) {
$validator->after(function ($validator) use ($props, $context) {
if (!$validator->errors()->get('reviewerId')) {
$reviewer = Repo::user()->get($props['reviewerId']);
if (!$reviewer) {
Expand All @@ -154,13 +154,15 @@ public function validate(?ReviewAssignment $object, array $props, Context $conte
$errors = $this->schemaService->formatValidationErrors($validator->errors());
}

Hook::call('Category::validate', [&$errors, $object, $props, $allowedLocales, $primaryLocale]);
Hook::run('ReviewAssignment::validate', [&$errors, $object, $props, $allowedLocales, $primaryLocale]);

return $errors;
}

/**
* Add a new review assignment
*
* @hook ReviewAssignment::add [[$reviewAssignment]]
*/
public function add(ReviewAssignment $reviewAssignment): int
{
Expand All @@ -174,6 +176,8 @@ public function add(ReviewAssignment $reviewAssignment): int

/**
* Edit a review assignment
*
* @hook ReviewAssignment::edit [[$newReviewAssignment, $reviewAssignment, $params]]
*/
public function edit(ReviewAssignment $reviewAssignment, array $params)
{
Expand All @@ -189,6 +193,8 @@ public function edit(ReviewAssignment $reviewAssignment, array $params)

/**
* Delete a review assignment
*
* @hook ReviewAssignment::delete::before [[$reviewAssignment]]
*/
public function delete(ReviewAssignment $reviewAssignment)
{
Expand Down

0 comments on commit 5679008

Please sign in to comment.