Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wasm/warg namespace cleanup #630

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

zeeshanlakhani
Copy link
Contributor

Summary

This PR mostly cleans up our wits. But, with updates to cargo-component and more, we have some new wasms and CIDs.

I updated the CBOR test to start with a JSON file before it writes to the fixtures and loads the file.

@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner March 27, 2024 02:31
@zeeshanlakhani zeeshanlakhani force-pushed the zl/homestar-namespace branch 2 times, most recently from 0a66e97 to 4ac2411 Compare March 27, 2024 14:12
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.95%. Comparing base (c2092b2) to head (9023719).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   69.80%   69.95%   +0.14%     
==========================================
  Files          98       98              
  Lines       13394    13394              
==========================================
+ Hits         9350     9370      +20     
+ Misses       4044     4024      -20     
Files Coverage Δ
homestar-functions/add/src/bindings.rs 0.00% <ø> (ø)
homestar-functions/subtract/src/bindings.rs 0.00% <ø> (ø)
homestar-invocation/src/task.rs 91.19% <100.00%> (ø)
homestar-invocation/src/task/instruction.rs 38.83% <100.00%> (ø)
homestar-runtime/src/network/webserver.rs 94.68% <ø> (ø)
homestar-runtime/src/network/webserver/listener.rs 89.47% <ø> (ø)
homestar-runtime/src/tasks/fetch.rs 100.00% <ø> (ø)
homestar-functions/test/src/bindings.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

@@ -157,6 +160,8 @@ represents the `Homestar` runtime. We recommend diving into each package's own
writing and compiling [Wasm component][wasm-component] modules using
[wit-bindgen][wit-bindgen].

You can find our component packages on [wa.dev][wa.dev-homestar].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice yeah, great to link to it. 💯

@zeeshanlakhani zeeshanlakhani merged commit 2d0cfe9 into main Mar 27, 2024
33 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/homestar-namespace branch March 27, 2024 21:19
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants