More Informative assert #1314
Merged
More Informative assert #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keep failing downstream in IPython. It's annoying. I hope this will give an idea as to why. Otherwise can we mark the test as xfail ? If not I"ll stop testing in IPython if I break ipykernel.
ianthomas23
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
I am happy to make this change permanently, or the xfail alternative if you'd prefer on a temporary basis.
There seem to be quite a lot of upstream and downstream failures in various related projects CI. This test here is somewhat risky as it is timing based and is probably best to relax it a bit, but I don't want to spend any more time on the subshells work here until the anyio changes are completed.
|
xfail, or make them with a specific flag so that they are not ran by default for now ? |
|
I'd go for |
|
I've added an xfail (non strict) |
|
Thanks @Carreau. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keep failing downstream in IPython. It's annoying. I hope this will give an idea as to why. Otherwise can we mark the test as xfail ?
If not I"ll stop testing in IPython if I break ipykernel.