Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicast address bugfix and improvements #979

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Multicast address bugfix and improvements #979

merged 2 commits into from
Aug 5, 2024

Conversation

ywc689
Copy link
Collaborator

@ywc689 ywc689 commented Jul 10, 2024 •
edited
Loading

  1. fix hw multicast address sync problems
  • Neglected the fact that multicast IPv4/IPv6 address can be mapped to one multicast hw address, and a lower dpvs port may have multiple upper ports (such as vlan).
  • Multicast hw addresses could sync from kni multiple times or be deleted by mistake.
  • Interferences of linked down kni devices.
  1. Add supports for getting dpvs multicast via dpip maddr.

@ywc689 ywc689 added the pr/to-review-codes review codes line by line and check if problem exists. label Jul 10, 2024
ywc689 added 2 commits July 10, 2024 18:31
@ywc689
netif_addr: fix hw multicast address sync problems
5c79c4f 
It fixes following problems in Previous implementation.
1. Neglected the fact that multicast IPv4/IPv6 address can be mapped to one multicast hw address,
   and a lower dpvs port may have multiple upper ports (such as vlan).
2. Multicast hw addresses could sync from kni multiple times or be deleted by mistake.
3. Interferences of linked down kni devices.

Signed-off-by: ywc689 <[email protected]>
@ywc689
dpip: add 'maddr' subcommand to show multicast addresses
5b2fc59 
Signed-off-by: ywc689 <[email protected]>
@ywc689 ywc689 added the pr/bug-confirmed the bug in the bugfix pr actually exists, and list cases can verify the effectiveness of the bugfix label Jul 10, 2024
@ywc689 ywc689 removed the request for review from you-looks-not-tasty August 1, 2024 02:03
ytwang0320
ytwang0320 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@ytwang0320 ytwang0320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve +1

@ytwang0320 ytwang0320 removed the pr/to-review-codes review codes line by line and check if problem exists. label Aug 2, 2024
@ywc689 ywc689 added the pr/accepted the pr passed all review stages and await to be merged label Aug 5, 2024
@ywc689 ywc689 merged commit c0b48af into iqiyi:devel Aug 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytwang0320 ytwang0320 ytwang0320 approved these changes

Assignees

@ytwang0320 ytwang0320

Labels
pr/accepted the pr passed all review stages and await to be merged pr/bug-confirmed the bug in the bugfix pr actually exists, and list cases can verify the effectiveness of the bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ywc689 @ytwang0320 @you-looks-not-tasty