Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#267] update tests for removed recursive operation 'pre-flight' output (4-3-stable) #269

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[#267] update tests for removed recursive operation 'pre-flight' output (4-3-stable) #269

merged 1 commit into from
Apr 26, 2024

Conversation

SwooshyCueb
Copy link
Member

Addresses #267

korydraughn
korydraughn reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Do the tests pass now?

@SwooshyCueb
Copy link
Member Author

SwooshyCueb commented Apr 25, 2024 •
edited
Loading

All except test_plugin_unified_storage_tiering.TestStorageTieringContinueInxMigration.test_put_gt_max_sql_rows, but it seems unrelated.

@korydraughn
Copy link
Collaborator

Is that the only test which fails consistently?

@SwooshyCueb
Copy link
Member Author

I haven't run it a second time yet, but so far it's the only one failing

@korydraughn
Copy link
Collaborator

Okay. Run it a few more times to see if it's consistent or intermittent. Based on the gist, it looks like it could be intermittent.

korydraughn
korydraughn approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in. Pound it.

@SwooshyCueb
Copy link
Member Author

#'d

@alanking alanking merged commit 28facc4 into irods:4-3-stable Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn approved these changes

@alanking alanking alanking approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwooshyCueb @korydraughn @alanking