[???] Add build action for PRs #370
Conversation
We probably want main to clean build?
This is taken from the GH docs. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries Note: This seems to just speed up cache eviction.
Caches are cleaned automatically.
|
After thinking about this a little more, making sure the project compiles correctly is more important than the amount of time taken to build it. Let's remove/disable ccache for now. |
|
Do we also want this to run on main, or just PRs? |
|
On PRs is good. See irods/irods for reference. |
|
I'll take out cache and put in a separate draft so we won't forget about it |
In that case, only thing to do is remove cache. Already only acts on PRs. |
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v4 | ||
| - name: Install Misc |
There was a problem hiding this comment.
Let's use the same wording as in irods/irods for this.
Install Prerequisites
There was a problem hiding this comment.
Avoided that name initially since I wasn't sure what exactly are the prerequisites.
| @@ -0,0 +1,54 @@ | |||
| name: iRODS HTTP API Builder | |||
There was a problem hiding this comment.
Looking at irods/irods, how do you feel about changing this to one of the following?
Build-Ubuntubuild-irods-http-api-ubuntu
Then we could expand this to cover other versions of Ubuntu, and later other platforms such as EL8 and EL9.
There was a problem hiding this comment.
I think it would be better without the hyphens. This name is supposed to be a user-facing name. You can see this in the passed checks at the bottom.
Perhaps we can name it so it ends up as Ubuntu iRODS HTTP API Builder / Build iRODS HTTP API - <Specific Ubuntu Image Here>?
There was a problem hiding this comment.
Sure. I don't think hyphens make it less readable.
Try expanding the builder workflow to support ub22/24, EL8/9 and see how the github actions report it. We want things to be sorted, grouped, and organized.
Aim for consistency across repos.
Take a look at the workflows for irods/irods.
| irods-dev=4.3.2-0~jammy \ | ||
| irods-runtime=4.3.2-0~jammy |
There was a problem hiding this comment.
Are we using 4.3.2 here because it's the declared minimum required version in the CMakeLists?
There was a problem hiding this comment.
4.3.2 since the builder docker file uses 4.3.2.
If we want, we could matrix this I think?
|
Also, needs an issue number. Seems good overall |
Ccache can be removed if we want a clean build every run.