Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds transaction hash to accounts overview page #217

Conversation

patnir
Copy link
Contributor

@patnir patnir commented Jun 25, 2024

Adds the hash of the transaction to the transactions list.

Makes it easier to identify a specific transaction especially when a lot of them have similar total values

image

@patnir patnir force-pushed the rahul/ifl-2718-add-transaction-hash-to-account-list-transaction-view-in branch from 89c8f53 to 1137a16 Compare June 25, 2024 20:37
@patnir patnir requested a review from dgca June 25, 2024 20:38
@dgca
Copy link
Contributor

dgca commented Jun 26, 2024

Screenshot 2024-06-26 at 10 15 35 AM

The hash card is missing its label on the smaller breakpoint.

Should we add the copy to clipboard functionality too? That'd make it easier to actually get the hash in case you need to paste it in the CLI

@patnir patnir force-pushed the rahul/ifl-2718-add-transaction-hash-to-account-list-transaction-view-in branch 5 times, most recently from 45b04e4 to 0320930 Compare June 26, 2024 21:47
adds heading text for smaller breakpoint view
adds ability to copy transaction hash to clipboard
copy to clipboard generalized functionality
@patnir patnir force-pushed the rahul/ifl-2718-add-transaction-hash-to-account-list-transaction-view-in branch from 0320930 to fbba1ea Compare August 19, 2024 16:51
@patnir
Copy link
Contributor Author

patnir commented Aug 19, 2024

Going to close this for now. This is a design change I suggested and I'll go through this change with Skylar when he has more bandwidth.

@patnir patnir closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants