Submit ledger network tx #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgca
commented
Aug 5, 2024
dgca
commented
- Submits ledger transaction to network after signing on ledger device
dgca
commented
Aug 5, 2024
| ]} | ||
| error={errors.fee?.message} | ||
| /> | ||
| {!selectedAccount.isLedger && ( |
There was a problem hiding this comment.
Note: I can't seem to estimate the fee with the ledger account since it's view only, so I'm hiding this input if the selected account is a ledger account
There was a problem hiding this comment.
It is possible to estimate gas for view only accounts but it can happen in another PR
There was a problem hiding this comment.
@patnir Might need your help there cause I'm not sure how to do that but we can follow up with that 👍
patnir
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.