Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ledger action to make ledger more reliable #5474

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

NullSoldier
Copy link
Contributor

@NullSoldier NullSoldier commented Oct 2, 2024

Summary

This UI action will handle many of the failure cases that occur when
running ledger commands. They'll use CLI-UX to inform the user of the
current state, and what the state should be.

TODO:

  • Make it work seemlessly when existing actions are running such as when using the interactive multisig server
  • Investigate issue with lock screen spamming

Testing Plan

  • Plug in a ledger and perform multisig with a server and without a server.
  • Plug in a ledger and perform multisig while hosting the server
  • Plug in a ledger and perform multisig while joining the server

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

@NullSoldier NullSoldier changed the base branch from staging to jason/dkg-identity October 2, 2024 23:45
@NullSoldier NullSoldier force-pushed the jason/dkg-identity branch 2 times, most recently from e4d448d to 6ae31e9 Compare October 3, 2024 06:58
@patnir
Copy link
Contributor

patnir commented Oct 3, 2024

Tested this with a bunch of cases - device falls asleep, i lock the device, and the app is not open.

image

Can your changes help identity which of the specific errors it is?

@patnir
Copy link
Contributor

patnir commented Oct 3, 2024

This is draft, but I would approve.

@NullSoldier NullSoldier force-pushed the jason/dkg-action branch 2 times, most recently from 752fe37 to a813ded Compare October 3, 2024 21:58
@NullSoldier NullSoldier force-pushed the jason/dkg-identity branch 2 times, most recently from 713fcb5 to 44be2bb Compare October 3, 2024 22:06
Base automatically changed from jason/dkg-identity to staging October 3, 2024 22:20
This UI action will handle many of the failure cases that occur when
running ledger commands. They'll use CLI-UX to inform the user of the
current state, and what the state should be.
@NullSoldier NullSoldier marked this pull request as ready for review October 3, 2024 22:25
@NullSoldier NullSoldier requested a review from a team as a code owner October 3, 2024 22:25
@NullSoldier NullSoldier changed the title WIP: Use ledger action to make ledger more reliable Use ledger action to make ledger more reliable Oct 3, 2024
Copy link
Contributor

@hughy hughy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out and works well!

I think as a future improvement we might move some log output out of the Ledger methods so that it doesn't repeat on retry. For example:
image

@NullSoldier NullSoldier force-pushed the jason/dkg-action branch 2 times, most recently from cf9c9ae to ab470da Compare October 7, 2024 04:18
@NullSoldier NullSoldier merged commit 5f1d60d into staging Oct 7, 2024
9 checks passed
@NullSoldier NullSoldier deleted the jason/dkg-action branch October 7, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants