Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Update transaction summary for chainport transactions #5494

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

rohanjadvani
Copy link
Member

@rohanjadvani rohanjadvani commented Oct 7, 2024

Summary

  • Show tx details even if there's an error fetching network details
  • Remove extra source information from logs
  • Use states in line with bridge prototype and update checks using Chainport API docs

Fixes IFL-3037

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

@rohanjadvani rohanjadvani self-assigned this Oct 7, 2024
@rohanjadvani rohanjadvani requested a review from a team as a code owner October 7, 2024 20:41
@dguenther dguenther merged commit 27db10e into staging Oct 8, 2024
10 of 11 checks passed
@dguenther dguenther deleted the update-transaction-summary branch October 8, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants