Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meteor.js to fix "iron run" command bug on windows #190

Merged
merged 2 commits into from Sep 1, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/tools/meteor.js
Original file line number Diff line number Diff line change
@@ -163,11 +163,12 @@ module.exports.invokeMeteorCommand = function invokeMeteorCommand(cmd, args) {

var future = new Future;

var child = spawn('meteor', [cmd].concat(args), {
var child = spawn(process.platform === "win32" ? 'meteor.bat' : 'meteor', [cmd].concat(args), {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is meteor.bat the windows executable?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah! @chrisbutler the exec file is "meteor.bat". and you can find it in here. ^_^

https://github.com/anticoders/gagarin/pull/127/files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisbutler bingo!

cwd: this.findAppDirectory(),
env: process.env
});


child.stdout.on('data', function stdout(data) {
console.log(data.toString());
});