Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE: Prompt a dialog when clicking 'Share' #311

Closed
wants to merge 5 commits into from

Conversation

dg-ac
Copy link
Contributor

@dg-ac dg-ac commented Feb 23, 2025

Note: this should address #304

This PR intends to prompt a dialog when users click on 'Share'. The reason behind this is to avoid them clicking 'Share' multiple times when sharing workbooks. It also includes a QR code with the idea of getting the mobile and desktop versions closers.

Should look like this:

image

To test it, please

  • Ensure the URL is created properly
  • Ensure the 'copy URL' button works properly
  • Ensure it's visible on mobile (not the QR code, as it's hidden on mobile devices)

Copy link
Member

@nhatcher nhatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
I deployed a version of this to try it out.
You will need to squash the commits and remove the WIP commit.
Let me know if you need help with that

@dg-ac
Copy link
Contributor Author

dg-ac commented Feb 26, 2025

Hi @nhatcher, thanks for the comments. Just pushed 2 commits, please take a look and resolve the pending conversations (unless there are open topics).

@nhatcher
Copy link
Member

Hi @dg-ac , there is a WIP commit (the first one)

@nhatcher
Copy link
Member

Superseded by #318

@nhatcher nhatcher closed this Feb 27, 2025
@dg-ac dg-ac deleted the update/dani-share-dialog branch March 8, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants