-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPDATE: Prompt a dialog when clicking 'Share' #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I deployed a version of this to try it out.
You will need to squash the commits and remove the WIP commit.
Let me know if you need help with that
webapp/app.ironcalc.com/frontend/src/components/ShareWorkbookDialog.tsx
Outdated
Show resolved
Hide resolved
webapp/app.ironcalc.com/frontend/src/components/ShareWorkbookDialog.tsx
Outdated
Show resolved
Hide resolved
Hi @nhatcher, thanks for the comments. Just pushed 2 commits, please take a look and resolve the pending conversations (unless there are open topics). |
Hi @dg-ac , there is a WIP commit (the first one) |
Superseded by #318 |
This PR intends to prompt a dialog when users click on 'Share'. The reason behind this is to avoid them clicking 'Share' multiple times when sharing workbooks. It also includes a QR code with the idea of getting the mobile and desktop versions closers.
Should look like this:
To test it, please