Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark entitytools methods as internal #23

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Mark entitytools methods as internal #23

merged 1 commit into from
Feb 19, 2024

Conversation

danigargar
Copy link
Contributor

Add @internal to every method in EntityTools except:

  • entityToDto
  • dtoToEntity
  • updateEntityByDto
  • lock
  • isScheduledForRemoval
  • clear
  • clearExcept
    /**
     * @internal 
     */

@danigargar danigargar changed the base branch from master to 4.x February 14, 2024 11:24
@danigargar
Copy link
Contributor Author

I made a draft-PR in ivoz-lib-demo requiring this branch, just for testing:
https://github.com/irontec/ivoz-lib-demo/pull/15

@danigargar danigargar self-assigned this Feb 14, 2024
@mmadariaga mmadariaga added the enhancement New feature or request label Feb 19, 2024
@danigargar danigargar force-pushed the CDD-17-mark-entitytools-methods-as-internal branch from 0222df6 to 892a75b Compare February 19, 2024 10:35
@danigargar danigargar merged commit 5228e7a into 4.x Feb 19, 2024
1 check passed
@danigargar danigargar deleted the CDD-17-mark-entitytools-methods-as-internal branch February 19, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmadariaga mmadariaga mmadariaga approved these changes

Assignees

@danigargar danigargar

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danigargar @mmadariaga