Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#464 check and fix minor translation issues #465

Merged
merged 5 commits into from
Jul 16, 2024
Merged

#464 check and fix minor translation issues #465

merged 5 commits into from
Jul 16, 2024

Conversation

sippsack
Copy link
Contributor

Removed TODO and fixed some translations in headings and typos in text

@sippsack sippsack linked an issue Jul 12, 2024 that may be closed by this pull request
check and fix minor translation issues #464
Closed
gernotstarke
gernotstarke requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@gernotstarke gernotstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest some changes, see detailed comments

@sippsack
Copy link
Contributor Author

Thanks for your suggestions, will work them in shortly

@sippsack sippsack requested a review from gernotstarke July 15, 2024 20:54
gernotstarke
gernotstarke requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@gernotstarke gernotstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor issue concerning "Nutzen" and "Vorteile", plus one grammatical issue...

gernotstarke
gernotstarke approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@gernotstarke gernotstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanx Falk!

@gernotstarke gernotstarke merged commit 18fbcf8 into main Jul 16, 2024
1 check passed
@programming-wolf programming-wolf deleted the 464-check-and-fix-minor-translation-issues branch July 24, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gernotstarke gernotstarke gernotstarke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check and fix minor translation issues
2 participants
@sippsack @gernotstarke