Handle References to Old LGs Consistently #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alxlo
commented
Mar 8, 2025
alxlo
commented
- numbers in old LGs had no leading zeros
- in some places this was correct (previously LG x-y), in some places we had x-0y, in some places even 0x-0y
- call me a bean counter
- numbers in old LGs had no leading zeros - in some places this was correct (previously LG x-y), in some places we had x-0y, in some places even 0x-0y - call me a bean counter
alxlo
requested review from
gernotstarke,
mikesperber,
programming-wolf and
rhoadesre
|
Build Successful! You can find a link to the downloadable artifacts below. |
gernotstarke
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.