Skip to content
This repository has been archived by the owner on Sep 18, 2022. It is now read-only.

[FIX] Phase guard #40

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

[FIX] Phase guard #40

wants to merge 2 commits into from

Conversation

samithiwat
Copy link
Contributor

Summary

LINEAR:

Which modules will your code affect?
How to test
Test Spec
  • ex. Case A...
Checklists
  • Unit test every code paths.
  • Locally test for happy and edge cases.
  • No duplicate code... if so refactor now.
  • No deprecated class/method.
  • No valid username/password/secret/key in any parts of this project
  • Database query
    • N/A
    • Already has index defined
    • No slowlog
  • API
    • N/A
    • Added API change in api-changes document/page
    • Support Batch API for reducing number of requests to minimum
    • Support Pagination
  • remote API call
    • N/A
    • Calling using Batch API for reducing number of requests to minimum
  • default value / overloading
    • N/A
    • Backward compatibility
  • config
    • N/A
    • Not expose the secret in config file
  • log kv
    • N/A
    • Key is snakecase
    • Ensure that there is no different data type of value of the same key to prevent log parser failure
  • Cherry-pick the commit to dev , prepared data and tested

Implement change
@samithiwat samithiwat self-assigned this Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant