Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TriangleMesh::SelectByIndex on CUDA #6556

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Dec 29, 2023

  • Use correct devices for attr tensors in SelectByIndex.
  • Fix documentation build error (lxml python package needs libxml2-dev and libxslt-dev)

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes Crash on close if using Tensor on CUDA device #6555 , CUDA CI failures
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Dec 29, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested a review from nsaiapova December 29, 2023 05:55
@ssheorey ssheorey force-pushed the ss/fix-selectbyindex-cuda branch 3 times, most recently from 1409a92 to f382849 Compare December 29, 2023 19:53
@ssheorey ssheorey closed this Dec 29, 2023
@ssheorey ssheorey reopened this Dec 29, 2023
@ssheorey ssheorey force-pushed the ss/fix-selectbyindex-cuda branch from f382849 to a4c9876 Compare December 30, 2023 05:57
@ssheorey ssheorey merged commit f3960d9 into main Dec 30, 2023
6 of 35 checks passed
@ssheorey ssheorey deleted the ss/fix-selectbyindex-cuda branch December 30, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on close if using Tensor on CUDA device
1 participant