fix: schema (#1203)

* fix: schema * fix: make feedback optional * chore: make feedback optional
isomerpages · Mar 11, 2024 · 85c560e · 85c560e
1 parent a66c503
commit 85c560e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/routes/v2/authenticated/sites.ts b/src/routes/v2/authenticated/sites.ts
@@ -179,7 +179,7 @@ export class SitesRouter {
   getPreviewInfo: RequestHandler<
     { siteName: string },
     PreviewInfo[] | ResponseErrorBody,
-    { sites: string[]; email: string },
+    { sites: string[] },
     never,
     { userSessionData: UserSessionData }
   > = async (req, res) => {

diff --git a/src/types/dto/feedback.ts b/src/types/dto/feedback.ts
@@ -2,7 +2,7 @@ import { UserType } from "../user"
 
 export interface FeedbackDto {
   rating: number
-  feedback: string
+  feedback?: string
   email: string
   userType: UserType
 }
diff --git a/src/validators/RequestSchema.js b/src/validators/RequestSchema.js
@@ -450,6 +450,9 @@ const CreateCollaboratorRequestSchema = Joi.object().keys({
 
 const CollateUserFeedbackRequestSchema = Joi.object().keys({
   userType: Joi.string().valid(...Object.values(UserTypes)),
+  rating: Joi.number().required(),
+  feedback: Joi.string().optional(),
+  email: Joi.string().required(),
 })
 
 const CreateReviewRequestSchema = Joi.object().keys({
@@ -473,7 +476,6 @@ const LaunchSiteSchema = Joi.object().keys({
 
 const GetPreviewInfoSchema = Joi.object().keys({
   sites: Joi.array().items(Joi.string()).required(),
-  email: EmailSchema,
 })
 
 const VerifyEmailOtpSchema = Joi.object().keys({