Add icon master to prevent crash with multiple tk instances (#270)

* add master to PhotoImage for window icon * bump version to 1.7.4.7
israel-dryer · Apr 21, 2022 · 63e8291 · 63e8291
1 parent 988a614
commit 63e8291
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/setup.py b/setup.py
@@ -70,7 +70,7 @@
 
 setuptools.setup(
     name="ttkbootstrap",
-    version="1.7.4.6",
+    version="1.7.4.7",
     author="Israel Dryer",
     author_email="[email protected]",
     description="A supercharged theme extension for tkinter that enables on-demand modern flat style themes inspired by Bootstrap.",

diff --git a/src/ttkbootstrap/window.py b/src/ttkbootstrap/window.py
@@ -209,17 +209,17 @@ def __init__(
         if iconphoto is not None:
             if iconphoto == '':
                 # the default ttkbootstrap icon
-                self._icon = tkinter.PhotoImage(data=Icon.icon)
+                self._icon = tkinter.PhotoImage(master=self, data=Icon.icon)
                 self.iconphoto(True, self._icon)
             else:
                 try:
                     # the user provided an image path
-                    self._icon = tkinter.PhotoImage(file=iconphoto)
+                    self._icon = tkinter.PhotoImage(file=iconphoto, master=self)
                     self.iconphoto(True, self._icon)
                 except tkinter.TclError:
                     # The fallback icon if the user icon fails.
                     print('iconphoto path is bad; using default image.')
-                    self._icon = tkinter.PhotoImage(data=Icon.icon)
+                    self._icon = tkinter.PhotoImage(data=Icon.icon, master=self)
                     self.iconphoto(True, self._icon)
 
         self.title(title)
@@ -402,7 +402,7 @@ def __init__(
         if iconphoto != '':
             try:
                 # the user provided an image path
-                self._icon = tkinter.PhotoImage(file=iconphoto)
+                self._icon = tkinter.PhotoImage(file=iconphoto, master=self)
                 self.iconphoto(True, self._icon)
             except tkinter.TclError:
                 # The fallback icon if the user icon fails.