-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css: Add CSS variables for better organization and flexibility #1001
Conversation
80a675d
to
86243b8
Compare
86243b8
to
762b300
Compare
Nice work, very cleanly done. LGTM as well. One thing though: I'll reiterate what I wrote in
This is potentially a breaking change as it drops support for IE10 (not sure whether we were compatible before, but now we definitely aren't). We should communicate that somewhere (changelog) and also drop the claim from the homepage (docs/index.html) about IE10 compatibility. |
Thank you for your attention to this matter. I understand that there may be differing opinions regarding whether to continue supporting a browser that is still in use but no longer receives updates from its developer, leaving it vulnerable to security risks. If needed, I can help with restoring support for IE 10 after this PR change. |
I might have miscommunicated here, IE10 support is not that important to me, but rather our claims to be compatible when we aren't anymore. |
Great, thanks for clarifying. |
Already done #1022 |
Checklist
CHANGES.rst
because this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
Added CSS variables to improve theme customization and organization in
isso.css
.Why is this necessary?
Closes #655