Update spring boot to v3.4.2 #583
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/spring-boot
branch
4 times, most recently
from
74e6090 to
6a6e65e
Compare
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request involves a systematic upgrade of the Spring Boot version across multiple microservices and common modules within the project. The
The update appears to be a coordinated version bump across the entire project's microservices ecosystem, suggesting a deliberate effort to standardize and update the Spring Boot framework version used throughout the application. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
renovate
bot
force-pushed
the
renovate/spring-boot
branch
4 times, most recently
from
34f1d63 to
02d405b
Compare
renovate
bot
force-pushed
the
renovate/spring-boot
branch
7 times, most recently
from
4f850a1 to
34f1f59
Compare
|
wls-common muss gehoben und released werden bevor die anderen Services gehoben werden können |
renovate
bot
force-pushed
the
renovate/spring-boot
branch
7 times, most recently
from
1ceadb2 to
6fc90e4
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/spring-boot
branch
from
6fc90e4 to
c629a88
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/spring-boot
branch
from
c629a88 to
f380c7d
Compare
renovate
bot
force-pushed
the
renovate/spring-boot
branch
3 times, most recently
from
32fbb0b to
a7e2f55
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (3)
wls-common/pom.xml (1)
26-26: Coordinate the release sequence.Since other services depend on
wls-common, this module must be:
- Updated to Spring Boot 3.4.1
- Released with a new version
- Referenced by other services with the new version
Current dependencies on wls-common:
- wls-eai-service uses version 1.1.0
- wls-briefwahl-service uses version 1.1.0
- wls-infomanagement-service uses version 1.1.0
wls-ergebnismeldung-service/pom.xml (1)
16-18: Consider a phased upgrade approach for better risk management.Given the dependency on
wls-commonand the number of services involved, consider the following upgrade strategy:
First Phase:
- Update and release
wls-commonto support Spring Boot 3.4.1- Run comprehensive integration tests
Second Phase:
- Upgrade a subset of services as a pilot
- Validate functionality and monitor for issues
Final Phase:
- Roll out to remaining services
- Consider blue-green deployment to minimize downtime
This approach allows for better risk management and easier rollback if issues arise.
Also applies to: 16-16, 16-16, 16-16, 18-18
wls-auth-service/pom.xml (1)
16-16: Consider implementing a parent POM for version managementTo better manage version upgrades across multiple services, consider:
- Creating a parent POM to centralize version management
- Using Maven BOMs for dependency management
- Implementing a CI/CD pipeline stage to verify version compatibility
This will:
- Reduce duplication across service POMs
- Simplify future version upgrades
- Ensure consistent dependency versions
- Make it easier to maintain compatibility between services
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
wls-admin-service/pom.xml(1 hunks)wls-auth-service/pom.xml(1 hunks)wls-basisdaten-service/pom.xml(1 hunks)wls-briefwahl-service/pom.xml(1 hunks)wls-broadcast-service/pom.xml(1 hunks)wls-common/pom.xml(1 hunks)wls-eai-service/pom.xml(1 hunks)wls-ergebnismeldung-service/pom.xml(1 hunks)wls-infomanagement-service/pom.xml(1 hunks)wls-monitoring-service/pom.xml(1 hunks)wls-vorfaelleundvorkommnisse-service/pom.xml(1 hunks)wls-wahlvorbereitung-service/pom.xml(1 hunks)wls-wahlvorstand-service/pom.xml(1 hunks)
🔇 Additional comments (12)
wls-admin-service/pom.xml (2)
18-18: Review Spring Boot 3.4.1 migration guide.Please review the Spring Boot 3.4.1 migration guide for potential breaking changes, especially in:
- Spring Security configuration
- JPA/Hibernate changes
- Actuator endpoints
- Web starter changes
18-18: Verify Oracle JDBC driver compatibility.The Oracle JDBC driver version 23.6.0.24.10 needs verification with Spring Boot 3.4.1:
- Check if the driver version is compatible
- Verify if any configuration changes are needed
Run this script to check Oracle driver compatibility:
wls-briefwahl-service/pom.xml (1)
17-17: Duplicate: Update wls-common dependency version.Same issue as in wls-eai-service: The wls-common dependency needs to be updated after its release with Spring Boot 3.4.1 support.
wls-infomanagement-service/pom.xml (1)
17-17: Duplicate: Update wls-common dependency version.Same issue as in wls-eai-service: The wls-common dependency needs to be updated after its release with Spring Boot 3.4.1 support.
wls-wahlvorbereitung-service/pom.xml (1)
17-17: Ensure correct update sequence for Spring Boot upgrade.Based on the PR comment,
wls-commonmust be updated and released before upgrading other services to Spring Boot 3.4.1. This service currently depends onwls-commonversion 1.1.0, which might not be compatible with Spring Boot 3.4.1.Run the following script to check the Spring Boot version used by the current wls-common dependency:
wls-broadcast-service/pom.xml (1)
16-16: Ensure correct update sequence for Spring Boot upgrade.wls-vorfaelleundvorkommnisse-service/pom.xml (1)
16-16: Ensure correct update sequence for Spring Boot upgrade.wls-monitoring-service/pom.xml (2)
16-16: Ensure correct update sequence for Spring Boot upgrade.
16-16: Verify OpenAPI generator compatibility with Spring Boot 3.4.1.The service uses openapi-generator-maven-plugin. Ensure that version 7.10.0 of the plugin is compatible with Spring Boot 3.4.1.
Run the following script to check for any known compatibility issues:
✅ Verification successful
Spring Boot 3.4.1 is compatible with OpenAPI Generator 7.10.0
OpenAPI Generator 7.10.0 fully supports Spring Boot 3.x series, and Spring Boot 3.4.1 is a valid, released version. No compatibility issues have been reported between these versions.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check OpenAPI Generator compatibility with Spring Boot 3.4.1 # Expected: No reported issues between these versions # Check GitHub issues for compatibility problems gh api graphql -f query=' { search(query: "repo:OpenAPITools/openapi-generator is:issue spring boot 3.4.1", type: ISSUE, first: 5) { nodes { ... on Issue { title url state } } } }'Length of output: 263
Script:
#!/bin/bash # Check OpenAPI generator version and Spring Boot version existence echo "=== Checking pom.xml for OpenAPI generator configuration ===" rg "openapi-generator-maven-plugin" -A 5 pom.xml echo -e "\n=== Verifying Spring Boot 3.4.1 existence ===" curl -s "https://search.maven.org/solrsearch/select?q=g:org.springframework.boot+AND+a:spring-boot&core=gav&rows=10&wt=json" | jq '.response.docs[] | select(.v | startswith("3.")) | .v'Length of output: 605
Script:
#!/bin/bash # Check OpenAPI generator version in the correct pom.xml echo "=== Checking wls-monitoring-service/pom.xml for OpenAPI generator configuration ===" rg "openapi-generator-maven-plugin" -A 5 wls-monitoring-service/pom.xmlLength of output: 500
wls-ergebnismeldung-service/pom.xml (2)
18-18: Ensure correct update sequence for Spring Boot upgrade.
18-18: Verify OpenAPI generator compatibility with Spring Boot 3.4.1.wls-wahlvorstand-service/pom.xml (1)
16-16: Ensure consistent version upgrade across all servicesThe Spring Boot version upgrade is consistent with other services.
wls-common/pom.xml
Outdated
| @@ -23,7 +23,7 @@ | |||
| <maven.compiler.target>${java.version}</maven.compiler.target> | |||
| <maven.compiler.release>${java.version}</maven.compiler.release> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <spring.boot.version>3.3.5</spring.boot.version> | |||
| <spring.boot.version>3.4.1</spring.boot.version> | |||
There was a problem hiding this comment.
💡 Codebase verification
Invalid Spring Boot version specified
Spring Boot version 3.4.1 does not exist. The latest Spring Boot 3.x version is in the 3.2.x series. Please use a valid Spring Boot version that is compatible with Spring Cloud 2023.0.5.
🔗 Analysis chain
Verify Spring Boot and Spring Cloud compatibility.
The Spring Boot upgrade to 3.4.1 with Spring Cloud 2023.0.5 needs verification:
- Spring Cloud 2023.0.5 was released for Spring Boot 3.2.x
- Spring Boot 3.4.1 might require a newer Spring Cloud version
Run this script to check version compatibility:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check Spring Cloud compatibility matrix
curl -s "https://spring.io/projects/spring-cloud#compatibility-matrix" | grep -A 5 "Spring Cloud 2023"
Length of output: 102
Script:
#!/bin/bash
# Check Spring Cloud release information
gh api repos/spring-cloud/spring-cloud-release/releases/tags/v2023.0.5 | jq -r '.body'
Length of output: 116
wls-eai-service/pom.xml
Outdated
| @@ -13,7 +13,7 @@ | |||
| <maven.compiler.target>${java.version}</maven.compiler.target> | |||
| <maven.compiler.release>${java.version}</maven.compiler.release> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <spring.boot.version>3.3.5</spring.boot.version> | |||
| <spring.boot.version>3.4.1</spring.boot.version> | |||
There was a problem hiding this comment.
Update wls-common dependency version.
The service uses wls-common 1.1.0, but this version might not be compatible with Spring Boot 3.4.1. Update the dependency after wls-common is released with Spring Boot 3.4.1 support.
wls-basisdaten-service/pom.xml
Outdated
| @@ -13,7 +13,7 @@ | |||
| <maven.compiler.target>${java.version}</maven.compiler.target> | |||
| <maven.compiler.release>${java.version}</maven.compiler.release> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <spring.boot.version>3.3.5</spring.boot.version> | |||
| <spring.boot.version>3.4.1</spring.boot.version> | |||
There was a problem hiding this comment.
💡 Codebase verification
Invalid Spring Boot version 3.4.1 specified
Spring Boot 3.4.1 is not a valid version. As of January 2025, the latest stable version is in the 3.2.x series. Please update to a released version of Spring Boot (e.g., 3.2.x) to ensure compatibility with Spring Cloud 2023.0.5.
🔗 Analysis chain
Verify Spring Boot 3.4.1 compatibility with Spring Cloud 2023.0.5
The Spring Boot version upgrade looks good, but we should verify compatibility with the Spring Cloud version.
Run this script to check the Spring Cloud compatibility matrix:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check Spring Cloud compatibility with Spring Boot 3.4.1
curl -s "https://spring.io/projects/spring-cloud#compatibility-matrix"
Length of output: 70
Script:
#!/bin/bash
# Check Spring Cloud version in pom.xml and search for Spring Boot dependency information in Spring Cloud docs
echo "=== Checking Spring Cloud version in pom.xml ==="
rg "spring-cloud" -A 5 pom.xml
echo -e "\n=== Fetching Spring Cloud release information ==="
curl -s "https://raw.githubusercontent.com/spring-cloud/spring-cloud-release/main/docs/src/main/asciidoc/spring-cloud-dependencies.adoc"
Length of output: 452
Script:
#!/bin/bash
# Check Spring Cloud version in the correct pom.xml path and query Maven Central
echo "=== Checking Spring Cloud version in pom.xml ==="
rg "spring-cloud" -A 5 "wls-basisdaten-service/pom.xml"
echo -e "\n=== Checking Spring Cloud 2023.0.5 metadata ==="
curl -s "https://search.maven.org/solrsearch/select?q=g:org.springframework.cloud+AND+a:spring-cloud-dependencies+AND+v:2023.0.5&rows=1&wt=json" | jq .
Length of output: 1806
wls-auth-service/pom.xml
Outdated
| @@ -13,7 +13,7 @@ | |||
| <maven.compiler.target>${java.version}</maven.compiler.target> | |||
| <maven.compiler.release>${java.version}</maven.compiler.release> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <spring.boot.version>3.3.5</spring.boot.version> | |||
| <spring.boot.version>3.4.1</spring.boot.version> | |||
There was a problem hiding this comment.
Address dependency upgrade order
Based on the comment "wls-common muss gehoben und released werden bevor die anderen Services gehoben werden können", the wls-common module should be upgraded and released first.
Please ensure the following upgrade order:
- Upgrade and release wls-common to Spring Boot 3.4.1
- Update the wls.common.version property in all services
- Proceed with upgrading the remaining services
renovate
bot
force-pushed
the
renovate/spring-boot
branch
2 times, most recently
from
007ba70 to
d8967f3
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/spring-boot
branch
17 times, most recently
from
6112a6f to
3689227
Compare
renovate
bot
force-pushed
the
renovate/spring-boot
branch
3 times, most recently
from
af63ae4 to
a3b1089
Compare
renovate
bot
force-pushed
the
renovate/spring-boot
branch
from
a3b1089 to
24d949c
Compare
renovate
bot
force-pushed
the
renovate/spring-boot
branch
from
24d949c to
9ed9c94
Compare
This PR contains the following updates:
3.3.5->3.4.23.3.5->3.4.2Release Notes
spring-projects/spring-boot (org.springframework.boot:spring-boot-dependencies)
v3.4.2Compare Source
🐞 Bug Fixes
📔 Documentation
@ConfigurationPropertiesannotation processor cannot generate description and defaultValue metadata for external types #43929@Fallbackbeans in ConditionalOnSingleCandidate's javadoc #43826🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@arefbehboudi, @dreis2211, @gavarava, @hezean, @izeye, @jxblum, @ngocnhan-tran1996, @nosan, @quaff, and @tmaciejewski
v3.4.1Compare Source
🐞 Bug Fixes
@SpringBootConfigurationresults in misleading error message #43507📔 Documentation
<annotationProcessorPaths>in Maven examples for configuring an annotation processor #43544@AutoConfigurationjavadoc #43325@EnableMethodSecurityinstead of the deprecated@EnableGlobalMethodSecurity#43315🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@BenchmarkingBuffalo, @Jae-Young98, @arefbehboudi, @izeye, @kgb-financial-com, @minwoo1999, @ngocnhan-tran1996, @nosan, @onobc, @quaff, @scordio, @sobychacko, and @vonZeppelin
v3.4.0Compare Source
⭐ New Features
🐞 Bug Fixes
@SpyBeanon the output of a FactoryBean is not reset #43053📔 Documentation
🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@ahoehma, @deki, @izeye, @ngocnhan-tran1996, @nosan, @quaff, and @wickdynex
v3.3.8Compare Source
🐞 Bug Fixes
📔 Documentation
@ConfigurationPropertiesannotation processor cannot generate description and defaultValue metadata for external types #43925🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@arefbehboudi, @dreis2211, @gavarava, @hezean, @izeye, @jxblum, @ngocnhan-tran1996, @quaff, and @tmaciejewski
v3.3.7Compare Source
🐞 Bug Fixes
@SpringBootConfigurationresults in misleading error message #43357📔 Documentation
<annotationProcessorPaths>in Maven examples for configuring an annotation processor #43329@AutoConfigurationjavadoc #43323@EnableMethodSecurityinstead of the deprecated@EnableGlobalMethodSecurity#43308🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@BenchmarkingBuffalo, @kgb-financial-com, @ngocnhan-tran1996, @nosan, @quaff, @scordio, and @sobychacko
v3.3.6Compare Source
🐞 Bug Fixes
@SpyBeanon the output of a FactoryBean is not reset #31204📔 Documentation
🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@ahoehma, @izeye, @ngocnhan-tran1996, @nosan, @quaff, and @wickdynex
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.