Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wls.common.version to v1.4.0 #729

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 16, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
de.muenchen.oss.wahllokalsystem.wls-common:testing 1.3.0 -> 1.4.0 age adoption passing confidence
de.muenchen.oss.wahllokalsystem.wls-common:security 1.3.0 -> 1.4.0 age adoption passing confidence
de.muenchen.oss.wahllokalsystem.wls-common:exception 1.3.0 -> 1.4.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the renovate renovate related stuff label Jan 16, 2025
Copy link
Contributor

coderabbitai bot commented Jan 16, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request updates the Maven project files for several services by modifying the <wls.common.version> property in each pom.xml. The version is consistently upgraded to 1.3.0 across all affected projects. Some modules were previously set to version 1.2.0, while others used 1.1.0. The updated files include those for projects such as wls-auth-service, wls-basisdaten-service, wls-briefwahl-service, wls-broadcast-service, wls-ergebnismeldung-service, wls-infomanagement-service, wls-monitoring-service, wls-vorfaelleundvorkommnisse-service, wls-wahlvorbereitung-service, and wls-admin-service. No additional alterations have been made to the configurations, dependencies, or any other properties in these files.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or `` anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@renovate renovate bot force-pushed the renovate/wls.common.version branch 5 times, most recently from b015904 to 85483ea Compare January 23, 2025 07:50
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (3)
wls-monitoring-service/pom.xml (1)

Line range hint 82-85: Align dependency version with property.

The exception module dependency uses a hardcoded version 1.1.0 while other modules use the ${wls.common.version} property. This inconsistency could lead to version conflicts.

Apply this diff to align the version:

 <dependency>
     <groupId>de.muenchen.oss.wahllokalsystem.wls-common</groupId>
     <artifactId>exception</artifactId>
-    <version>1.1.0</version>
+    <version>${wls.common.version}</version>
 </dependency>
wls-ergebnismeldung-service/pom.xml (1)

Line range hint 82-85: Align dependency version with property.

The exception module dependency uses a hardcoded version 1.1.0 while other modules use the ${wls.common.version} property. This inconsistency could lead to version conflicts.

Apply this diff to align the version:

 <dependency>
     <groupId>de.muenchen.oss.wahllokalsystem.wls-common</groupId>
     <artifactId>exception</artifactId>
-    <version>1.1.0</version>
+    <version>${wls.common.version}</version>
 </dependency>
wls-basisdaten-service/pom.xml (1)

Line range hint 82-85: Align dependency version with property.

The exception module dependency uses a hardcoded version 1.1.0 while other modules use the ${wls.common.version} property. This inconsistency could lead to version conflicts.

Apply this diff to align the version:

 <dependency>
     <groupId>de.muenchen.oss.wahllokalsystem.wls-common</groupId>
     <artifactId>exception</artifactId>
-    <version>1.1.0</version>
+    <version>${wls.common.version}</version>
 </dependency>
🧹 Nitpick comments (1)
wls-vorfaelleundvorkommnisse-service/pom.xml (1)

39-40: Holistic Assessment: The version update is well-structured and consistent.

The PR successfully updates wls.common.version from 1.1.0 to 1.2.0 across all services. The property-based approach ensures consistent versioning of the three affected artifacts (testing, security, and exception). The minor version bump (1.1.0 -> 1.2.0) suggests backward-compatible new features.

Key observations:

  1. Consistent version update across all services
  2. Proper dependency management using Maven properties
  3. Affects both runtime and test dependencies
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ab4f35 and 85483ea.

📒 Files selected for processing (10)
  • wls-auth-service/pom.xml (1 hunks)
  • wls-basisdaten-service/pom.xml (1 hunks)
  • wls-briefwahl-service/pom.xml (1 hunks)
  • wls-broadcast-service/pom.xml (1 hunks)
  • wls-ergebnismeldung-service/pom.xml (1 hunks)
  • wls-infomanagement-service/pom.xml (1 hunks)
  • wls-monitoring-service/pom.xml (1 hunks)
  • wls-vorfaelleundvorkommnisse-service/pom.xml (1 hunks)
  • wls-wahlvorbereitung-service/pom.xml (1 hunks)
  • wls-wahlvorstand-service/pom.xml (1 hunks)
🔇 Additional comments (9)
wls-briefwahl-service/pom.xml (1)

40-40: LGTM: Version update is consistent.

The update of wls.common.version to 1.2.0 correctly propagates to both the runtime security dependency and test dependency.

wls-infomanagement-service/pom.xml (1)

40-40: LGTM: Version update is consistent.

The update of wls.common.version to 1.2.0 correctly propagates to both the runtime exception dependency and test dependency.

wls-wahlvorbereitung-service/pom.xml (1)

40-40: LGTM: Version update is consistent.

The update of wls.common.version to 1.2.0 correctly propagates to both the runtime security dependency and test dependency.

wls-broadcast-service/pom.xml (1)

39-39: LGTM: Version update is consistent.

The update of wls.common.version to 1.2.0 correctly propagates to both the runtime exception dependency and test dependency.

wls-vorfaelleundvorkommnisse-service/pom.xml (2)

39-39: LGTM: Version update is consistent.

The update of wls.common.version to 1.2.0 correctly propagates to both the runtime security dependency and test dependency.


39-39: Verify breaking changes in wls-common v1.2.0.

Since this is a minor version update of wls-common from 1.1.0 to 1.2.0 across multiple services, let's verify there are no breaking changes that could affect the services.

Run the following script to check the changelog or release notes:

✅ Verification successful

No breaking changes detected in wls-common 1.2.0

The minor version update from 1.1.0 to 1.2.0 maintains backward compatibility. The module's core components (security, exception handling, and testing utilities) preserve their public APIs and interfaces.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for breaking changes in wls-common v1.2.0

# Fetch release information from GitHub
gh api graphql -f query='
{
  repository(owner: "it-at-m", name: "Wahllokalsystem") {
    release(tagName: "wls-common-1.2.0") {
      description
      url
    }
  }
}'

# Search for migration guides or upgrade notes
rg -i -g "*.md" "upgrade|migration|breaking.?changes|compatibility" 

Length of output: 2986


Script:

#!/bin/bash
# Find wls-common module and examine changes
fd -t d "wls-common$"

# If found, examine git changes between versions
git log --oneline wls-common-1.1.0..wls-common-1.2.0 2>/dev/null || echo "Tags not found"

# Look for Java files in wls-common to analyze API surface
fd -e java -t f . 2>/dev/null

# Search for potential API changes (public methods/classes)
rg "public (class|interface|enum)" -t java

Length of output: 65636


Script:

#!/bin/bash
# Search for public interfaces/classes specifically in wls-common
rg "public (class|interface|enum)" -t java ./wls-common/

# Look for all Java files in wls-common to ensure we don't miss anything
fd -e java -t f . ./wls-common/

Length of output: 11098

wls-wahlvorstand-service/pom.xml (1)

39-39: LGTM!

The version update is consistent across all module dependencies.

wls-auth-service/pom.xml (2)

39-39: LGTM!

The version update is consistent across all module dependencies.


39-39: Verify breaking changes in wls-common v1.2.0.

Please ensure that there are no breaking changes in the new version that could affect the dependent services.

Run the following script to check the changelog or release notes:

@renovate renovate bot force-pushed the renovate/wls.common.version branch 17 times, most recently from c7cebe5 to d653bc8 Compare January 30, 2025 09:36
@renovate renovate bot force-pushed the renovate/wls.common.version branch 3 times, most recently from e567289 to 633485f Compare February 6, 2025 12:15
@renovate renovate bot force-pushed the renovate/wls.common.version branch 2 times, most recently from ded5f36 to 4399563 Compare February 7, 2025 14:27
@renovate renovate bot force-pushed the renovate/wls.common.version branch 6 times, most recently from f6083ca to 7e4e4be Compare March 6, 2025 13:12
@renovate renovate bot force-pushed the renovate/wls.common.version branch from 7e4e4be to 22ab49f Compare March 6, 2025 15:50
@renovate renovate bot force-pushed the renovate/wls.common.version branch 9 times, most recently from f1d9aec to 5e1b0ba Compare March 7, 2025 13:25
@renovate renovate bot changed the title Update wls.common.version to v1.3.0 Update wls.common.version to v1.4.0 Mar 7, 2025
@renovate renovate bot force-pushed the renovate/wls.common.version branch from 5e1b0ba to d999e48 Compare March 7, 2025 14:49
@renovate renovate bot force-pushed the renovate/wls.common.version branch from d999e48 to 0375517 Compare March 7, 2025 15:47
@renovate renovate bot force-pushed the renovate/wls.common.version branch from 0375517 to 800d371 Compare March 10, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant