Update wls.common.version to v1.2.0 #729
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request involves a consistent version update of the
The modification is limited to the version property within the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
renovate
bot
force-pushed
the
renovate/wls.common.version
branch
5 times, most recently
from
b015904 to
85483ea
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (3)
wls-monitoring-service/pom.xml (1)
Line range hint
82-85: Align dependency version with property.The
exceptionmodule dependency uses a hardcoded version1.1.0while other modules use the${wls.common.version}property. This inconsistency could lead to version conflicts.Apply this diff to align the version:
<dependency> <groupId>de.muenchen.oss.wahllokalsystem.wls-common</groupId> <artifactId>exception</artifactId> - <version>1.1.0</version> + <version>${wls.common.version}</version> </dependency>wls-ergebnismeldung-service/pom.xml (1)
Line range hint
82-85: Align dependency version with property.The
exceptionmodule dependency uses a hardcoded version1.1.0while other modules use the${wls.common.version}property. This inconsistency could lead to version conflicts.Apply this diff to align the version:
<dependency> <groupId>de.muenchen.oss.wahllokalsystem.wls-common</groupId> <artifactId>exception</artifactId> - <version>1.1.0</version> + <version>${wls.common.version}</version> </dependency>wls-basisdaten-service/pom.xml (1)
Line range hint
82-85: Align dependency version with property.The
exceptionmodule dependency uses a hardcoded version1.1.0while other modules use the${wls.common.version}property. This inconsistency could lead to version conflicts.Apply this diff to align the version:
<dependency> <groupId>de.muenchen.oss.wahllokalsystem.wls-common</groupId> <artifactId>exception</artifactId> - <version>1.1.0</version> + <version>${wls.common.version}</version> </dependency>
🧹 Nitpick comments (1)
wls-vorfaelleundvorkommnisse-service/pom.xml (1)
39-40: Holistic Assessment: The version update is well-structured and consistent.The PR successfully updates
wls.common.versionfrom 1.1.0 to 1.2.0 across all services. The property-based approach ensures consistent versioning of the three affected artifacts (testing, security, and exception). The minor version bump (1.1.0 -> 1.2.0) suggests backward-compatible new features.Key observations:
- Consistent version update across all services
- Proper dependency management using Maven properties
- Affects both runtime and test dependencies
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
wls-auth-service/pom.xml(1 hunks)wls-basisdaten-service/pom.xml(1 hunks)wls-briefwahl-service/pom.xml(1 hunks)wls-broadcast-service/pom.xml(1 hunks)wls-ergebnismeldung-service/pom.xml(1 hunks)wls-infomanagement-service/pom.xml(1 hunks)wls-monitoring-service/pom.xml(1 hunks)wls-vorfaelleundvorkommnisse-service/pom.xml(1 hunks)wls-wahlvorbereitung-service/pom.xml(1 hunks)wls-wahlvorstand-service/pom.xml(1 hunks)
🔇 Additional comments (9)
wls-briefwahl-service/pom.xml (1)
40-40: LGTM: Version update is consistent.The update of
wls.common.versionto1.2.0correctly propagates to both the runtime security dependency and test dependency.wls-infomanagement-service/pom.xml (1)
40-40: LGTM: Version update is consistent.The update of
wls.common.versionto1.2.0correctly propagates to both the runtime exception dependency and test dependency.wls-wahlvorbereitung-service/pom.xml (1)
40-40: LGTM: Version update is consistent.The update of
wls.common.versionto1.2.0correctly propagates to both the runtime security dependency and test dependency.wls-broadcast-service/pom.xml (1)
39-39: LGTM: Version update is consistent.The update of
wls.common.versionto1.2.0correctly propagates to both the runtime exception dependency and test dependency.wls-vorfaelleundvorkommnisse-service/pom.xml (2)
39-39: LGTM: Version update is consistent.The update of
wls.common.versionto1.2.0correctly propagates to both the runtime security dependency and test dependency.
39-39: Verify breaking changes in wls-common v1.2.0.Since this is a minor version update of
wls-commonfrom 1.1.0 to 1.2.0 across multiple services, let's verify there are no breaking changes that could affect the services.Run the following script to check the changelog or release notes:
✅ Verification successful
No breaking changes detected in wls-common 1.2.0
The minor version update from 1.1.0 to 1.2.0 maintains backward compatibility. The module's core components (security, exception handling, and testing utilities) preserve their public APIs and interfaces.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for breaking changes in wls-common v1.2.0 # Fetch release information from GitHub gh api graphql -f query=' { repository(owner: "it-at-m", name: "Wahllokalsystem") { release(tagName: "wls-common-1.2.0") { description url } } }' # Search for migration guides or upgrade notes rg -i -g "*.md" "upgrade|migration|breaking.?changes|compatibility"Length of output: 2986
Script:
#!/bin/bash # Find wls-common module and examine changes fd -t d "wls-common$" # If found, examine git changes between versions git log --oneline wls-common-1.1.0..wls-common-1.2.0 2>/dev/null || echo "Tags not found" # Look for Java files in wls-common to analyze API surface fd -e java -t f . 2>/dev/null # Search for potential API changes (public methods/classes) rg "public (class|interface|enum)" -t javaLength of output: 65636
Script:
#!/bin/bash # Search for public interfaces/classes specifically in wls-common rg "public (class|interface|enum)" -t java ./wls-common/ # Look for all Java files in wls-common to ensure we don't miss anything fd -e java -t f . ./wls-common/Length of output: 11098
wls-wahlvorstand-service/pom.xml (1)
39-39: LGTM!The version update is consistent across all module dependencies.
wls-auth-service/pom.xml (2)
39-39: LGTM!The version update is consistent across all module dependencies.
39-39: Verify breaking changes in wls-common v1.2.0.Please ensure that there are no breaking changes in the new version that could affect the dependent services.
Run the following script to check the changelog or release notes:
renovate
bot
force-pushed
the
renovate/wls.common.version
branch
17 times, most recently
from
c7cebe5 to
d653bc8
Compare
renovate
bot
force-pushed
the
renovate/wls.common.version
branch
from
d653bc8 to
0b1da79
Compare
renovate
bot
force-pushed
the
renovate/wls.common.version
branch
from
0b1da79 to
e567289
Compare
This PR contains the following updates:
1.1.0->1.2.01.1.0->1.2.01.1.0->1.2.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit
wls.commonlibrary version from1.1.0to1.2.0across multiple services, including: