Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

805 openapi generator pretends path elements of method parameters in controller to be annotated as path variables #813

Conversation

Nic12345678
Copy link
Contributor

@Nic12345678 Nic12345678 commented Feb 12, 2025

Nach der API-Korrektur (Klein- zu Großbuchstabe in eingenomene(w)[W]ahlscheine), siehe #776 musste ein neues Release vom Ergebnismeldung-Service gebaut werden, bzw. das neue korrekte openapi.json-File wird für andere Clients benötigt.

Die oben erwähnte Korrektur wurde im #800 bereits reviewed und gemerged.

Danach wurde beim Versuch aus openapi.json des so releaseten ergebnismeldung-service über den openapi-generator die Clients für den wls-admin-service zu generieren festgestellt, dass im ergebnismeldung-service im Controller in der Methode sendErgebnisse das Objekt-Paramter nicht akzeptiert wurde, sondern der Generator PathVariablen verlangte. So ist #805 entstanden.

#805 wurde im PR 810 reviewed und gemerged.

Danach wurde manuell die beim PR800 entstandene SNAPSHOT Version auf 0.2.1-SNAPSHOT erhöht, weil ein Release 0.2.0 bereits existierte und wir deshalb ein Release 0.2.1 anstreben.

Wegen der Trivialität haben wir uns entschieden das Releasen infolge der Korrektur mit dem gleichen Issue zu erledigen, jedoch in einem neuen PR (diesem).

Definition of Done (DoD):

  • es gibt eine Release Version

  • nächste Development Version ist vorhanden

Closes #805

Summary by CodeRabbit

  • Chores
    • Updated the project version to the latest release.
  • Style
    • Refined internal configuration formatting to improve consistency.

Copy link
Contributor

coderabbitai bot commented Feb 12, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request modifies the build configuration in the wls-ergebnismeldung-service/pom.xml file. The project version is updated from 0.2.0-SNAPSHOT to 0.2.2-SNAPSHOT. Additionally, the formatting of the XML has been adjusted; the <project> tag is now presented in a single line rather than across multiple lines. There are also minor formatting changes to the self-closing tags for <trimTrailingWhitespace/> and <endWithNewline/> within the configuration of the spotless-maven-plugin, changing them to <trimTrailingWhitespace /> and <endWithNewline /> respectively. These changes do not affect the core functionality or dependencies but are focused on version management and formatting consistency in the XML file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or `` anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

…of-method-parameters-in-controller-to-be-annotated-as-path-variables
@MrSebastian MrSebastian self-requested a review February 13, 2025 08:10
@Nic12345678 Nic12345678 merged commit 1f3dd0c into dev Feb 13, 2025
5 checks passed
@Nic12345678 Nic12345678 deleted the 805-openapi-generator-pretends-path-elements-of-method-parameters-in-controller-to-be-annotated-as-path-variables branch February 13, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openapi-Generator pretends path elements of method parameters in controller to be annotated as Path-Variables
2 participants