Merge pull request #728 from italia/feature/url_fragments

URL Fragments instead of Path params.
italia · Oct 2, 2024 · 651000e · 651000e
2 parents a2939ad + ccb737d
commit 651000e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/components/ShowButton.js b/src/components/ShowButton.js
@@ -19,7 +19,7 @@ export const ShowButton = () => {
     if (isDocumentTextTooLong(documentText)) {
       alert('Snippet is too long.');
     } else {
-      const url = `${window.location.origin}${window.location.pathname}?text=${b64url_encode(documentText)}`;
+      const url = `${window.location.origin}${window.location.pathname}#text=${b64url_encode(documentText)}`;
       if (window.navigator.clipboard) {
         window.navigator.clipboard.writeText(url).then(() => {
           alert('Snippet url copied to clipboard!');

diff --git a/src/redux/reducers/documentReducer.js b/src/redux/reducers/documentReducer.js
@@ -1,12 +1,14 @@
 import { FOCUS_DOCUMENT_LINE, SET_DOCUMENT_URL, SET_DOCUMENT_TEXT } from '../actionTypes.js';
 import { DEFAULT_DOCUMENT_URL } from '../../utils.mjs';
 
-const queryParams = new URLSearchParams(window.location.search);
+// Replace query string with fragment
+const hashParams = new URLSearchParams(window.location.hash.substring(1)); // Get params from fragment
+
 const initialState = {
   focusLine: null,
   text: null,
-  textParameter: queryParams.get('text') || null,
-  url: queryParams.get('text') ? null : queryParams.get('url') || DEFAULT_DOCUMENT_URL,
+  textParameter: hashParams.get('text') || null, // Get 'text' from fragment
+  url: hashParams.get('text') ? null : hashParams.get('url') || DEFAULT_DOCUMENT_URL, // Get 'url' from fragment or use default
 };
 
 export default function (state = initialState, action) {