Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed grid container for XL breakpoint #1099

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Conversation

zetareticoli
Copy link
Member

Updated the grid container width for XL breakpoint, following the update from UI kit Italia and Bootstrap Italia.

Copy link
Contributor

github-actions bot commented Nov 24, 2023

⚡ Lighthouse report for the home page 🏠

Category Score
🟠 Performance 52
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

See the full report...

Other pages

@Fupete
Copy link
Collaborator

Fupete commented Nov 24, 2023

@zetareticoli we must wait for the merge and release of this in a new version of BSI (cc @astagi), and we must prepare a new release of UI Kit Italia before merging this. Is this correct?
I think we can schedule this all for next week. For the time being, I will move the discussion to draft.

@zetareticoli zetareticoli self-assigned this Nov 24, 2023
@zetareticoli zetareticoli marked this pull request as ready for review November 24, 2023 10:06
@Fupete Fupete marked this pull request as draft November 24, 2023 10:06
@zetareticoli zetareticoli marked this pull request as ready for review November 24, 2023 10:37
@Fupete
Copy link
Collaborator

Fupete commented Nov 24, 2023

Just a reminder: this is approved, but we need to wait BSI and UI Kit Italia fix releases before merging in the next release of the DS alpha.15 scheduled for next week.

@Fupete
Copy link
Collaborator

Fupete commented Nov 28, 2023

Update: just merged this in Bootstrap Italia. We wait for the new release of BSI (@astagi) and for our new release of UI Kit Italia (@zetareticoli @Fupete) next days before merging.

@Fupete Fupete merged commit 9f74cbd into main Dec 14, 2023
4 checks passed
@Fupete Fupete deleted the fix/grid-breakpoint-xl branch December 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants