-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18n server #61
I18n server #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we have four views in flow:
- main-content
- email-sent
- register-confirm
- confirmed
We must provide localisation for all views and even for email.mst which represent the template for email sent
</div> | ||
|
||
<div class="form-group active child"> | ||
<input type="text" class="form-control-plaintext active readonly" id="nomeAmministrazione" tabindex="-1" | ||
required> | ||
<label for="nomeAmministrazione">Amministrazione *</label> | ||
<label for="nomeAmministrazione">{{main.nomeAmministrazione}}</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be {{main.labelnomeAmministrazione}}
Quoting @sebbalex 's comment, I also believe that in order to merge this PR and close the relative issue an extra effort should be done to consolidate all the views. Are you able to proceed in this direction @gtico80 or you need some assistance? Thanks a lot for your precious work! 🚀 |
Hi @gtico80, I believe that in order to be able to correctly review this PR it is necessary to rebase your branch against our master and consequently run the linter. When trying to run it (with node 12.4.0), I found several problems and the application could not even start. If you need assistance during the rebasing process please let us know! Thanks a lot / cc @sebbalex |
Hi @gtico80, if you want we can rebase your branch against our master and push on your fork so that we can test this PR further and merge it. What do you think? Thanks a lot! |
We can try but probably it is better to fix issue #65 otherwise it is difficult to test it |
@gtico80 we are planning on refactoring the whole site and use a static approach for the frontend, I'm gonna close this one as it's stale but despite that, your work on it was appreciated. |
Issue #45 labels main and infrastructure