-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Added Mongo Storage and cache #31
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | a531dc0 | pyeudiw/satosa/backend.py | View secret |
- | Generic High Entropy Secret | 1c89900 | pyeudiw/satosa/backend.py | View secret |
- | Generic High Entropy Secret | 1545a03 | pyeudiw/satosa/backend.py | View secret |
- | RSA Private Key | bd58830 | satosa/idp_proxy/pki/privkey.pem | View secret |
- | Generic High Entropy Secret | 5f898d5 | pyeudiw/satosa/backend.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
docker-compose.yml
Outdated
networks: | ||
- wordpress-network | ||
|
||
phpmyadmin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please comment this to leave it at the will of the user having phpadmin or not
example/satosa/pyeudiw_backend.yaml
Outdated
@@ -71,6 +73,8 @@ config: | |||
use: sig | |||
x5c: | |||
- '...' | |||
# time in ms | |||
token_exp_delta: 600000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this collides with the new configuration, please use it
pyeudiw/satosa/backend.py
Outdated
|
||
self.absolute_redirect_url = config['wallet_relying_party']['redirect_uris'][0] | ||
self.absolute_request_url = config['wallet_relying_party']['request_uris'][0] | ||
|
||
self.qrcode_settings = config['qrcode_settings'] | ||
self.qr_settings = config['qr_code_settings'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has changed in dev branch, please align this accordingly
pyeudiw/satosa/backend.py
Outdated
|
||
self.absolute_redirect_url = config['wallet_relying_party']['redirect_uris'][0] | ||
self.absolute_request_url = config['wallet_relying_party']['request_uris'][0] | ||
|
||
self.qrcode_settings = config['qrcode_settings'] | ||
self.qr_settings = config['qr_code_settings'] | ||
self.token_exp_delta = config['jwks']['token_exp_delta'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same comment as the previous
No description provided.