Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added Mongo Storage and cache #31

Merged
merged 28 commits into from
Jul 25, 2023

Conversation

PascalDR
Copy link
Collaborator

No description provided.

@PascalDR PascalDR requested a review from peppelinux July 24, 2023 11:10
@gitguardian
Copy link

gitguardian bot commented Jul 24, 2023

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret a531dc0 pyeudiw/satosa/backend.py View secret
- Generic High Entropy Secret 1c89900 pyeudiw/satosa/backend.py View secret
- Generic High Entropy Secret 1545a03 pyeudiw/satosa/backend.py View secret
- RSA Private Key bd58830 satosa/idp_proxy/pki/privkey.pem View secret
- Generic High Entropy Secret 5f898d5 pyeudiw/satosa/backend.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

networks:
- wordpress-network

phpmyadmin:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please comment this to leave it at the will of the user having phpadmin or not

@@ -71,6 +73,8 @@ config:
use: sig
x5c:
- '...'
# time in ms
token_exp_delta: 600000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this collides with the new configuration, please use it


self.absolute_redirect_url = config['wallet_relying_party']['redirect_uris'][0]
self.absolute_request_url = config['wallet_relying_party']['request_uris'][0]

self.qrcode_settings = config['qrcode_settings']
self.qr_settings = config['qr_code_settings']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has changed in dev branch, please align this accordingly


self.absolute_redirect_url = config['wallet_relying_party']['redirect_uris'][0]
self.absolute_request_url = config['wallet_relying_party']['request_uris'][0]

self.qrcode_settings = config['qrcode_settings']
self.qr_settings = config['qr_code_settings']
self.token_exp_delta = config['jwks']['token_exp_delta']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same comment as the previous

@peppelinux peppelinux merged commit 67e6fec into italia:dev Jul 25, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants