Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satosa disco login #32

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Conversation

MurruAlessio
Copy link
Collaborator

@MurruAlessio
Copy link
Collaborator Author

image

@Pyscho79 Pyscho79 added this to the 0.2.0 milestone Jul 25, 2023
@RosaliaGaleano
Copy link
Collaborator

RosaliaGaleano commented Jul 26, 2023

I share some comments below about the page:

Fix composition:

  • I suggest moving the disclaimer component to the bottom;

Fix copy:

  • Update the disclaimer;
  • Update the subtitle describing access with IT Wallet;
  • Update the descriptive subtitle of access with CIE and SPID.
    (In the figma file you will find copy proposals but they are still being validated internally)

Fix components:

  • Enlarge the icon of the external link next to "identitadigitale.gov.it";
  • Adjust the space between the external link icon and the text "identitadigitale.gov.it";
  • Adjust the space between the icon and the text inside all the buttons;
  • Update the eIDAS button icon (fix also the word eIDAS);
  • I suggest to use the colour blue (provided in the UI Kit) for the disclaimer component to make the message more informative and less alarming.

Let me know if it is necessary to open new issues or not.

@MurruAlessio
Copy link
Collaborator Author

I finished the requested changes: below is the screenshot with the new layout.
image

@Pyscho79 Pyscho79 changed the base branch from dev to dev-legacy July 26, 2023 17:19
@gitguardian
Copy link

gitguardian bot commented Jul 26, 2023

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7115788 Generic High Entropy Secret 6f65b8c eudi_wallet_python/satosa/backend.py View secret
7115788 Generic High Entropy Secret 8f7bfea eudi_wallet_python/satosa/backend.py View secret
7115788 Generic High Entropy Secret 61138a4 eudi_wallet_python/satosa/backend.py View secret
7115788 Generic High Entropy Secret bb52f91 pyeudiw/satosa/backend.py View secret
7316502 RSA Private Key 1c46fd8 satosa/idp_proxy/pki/privkey.pem View secret
7115788 Generic High Entropy Secret 6748ef7 pyeudiw/satosa/backend.py View secret
7115788 Generic High Entropy Secret e0473ae pyeudiw/satosa/backend.py View secret
7115788 Generic High Entropy Secret ac9918e pyeudiw/satosa/backend.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Pyscho79 Pyscho79 changed the base branch from dev-legacy to dev July 26, 2023 17:19
@peppelinux peppelinux merged commit 669916e into italia:dev Jul 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment