-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: dpop #35
test: dpop #35
Conversation
is_valid MUST return a boolean please specify it if not already defined in the property/function definition in the test we have to assert true or false, depending by the scope of the test |
we must tests situation where the dpop is invalid or with a wrong schema, the tests we need wants to cover also the security aspects and not just the assertion to wellknown parameter, that we have used in the tests |
As you can see, the test cases for the DPoPVerifier are cases in which we expect the function to return |
While testing the property
is_valid
ofDPoPVerifier
, I found out it can fail on some invalid inputs.Specifically, you can find some commented out test cases which causes the aforementioned property to raise different errors on not-valid inputs. Do you prefer to address those cases, for example, by returning
False
if any of the underlying checks raise an error, or we keep it as it is?