Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more protocols in URL fields. #113

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bfabio
Copy link
Member

@bfabio bfabio commented Nov 8, 2019

Allow repositories with ssh:// (and its short git form),
git://, svn://, svn+ssh:// as protocol in URL fields, via
a new "repourl" field type.

Also, use https:// as the placeholder for URL fields, to
drop a hint to the user about the nature of such fields.

Allow repositories with ssh:// (and its short git form),
git://, svn://, svn+ssh:// as protocol in URL fields, via
a new "repourl" field type.

Also, use https:// as the placeholder for URL fields, to
drop a hint to the user about the nature of such fields.
@libremente
Copy link
Member

@bfabio you are right, the publiccode.yml says that the protocols you mentioned could be entered. However, when checking that URL I believe the crawler makes some HTTP GETs but I need to double check that code and get back to you. cc @sebbalex

@bfabio
Copy link
Member Author

bfabio commented Mar 18, 2020

@libremente I think you're right: crawler/crawler/crawler.go#L268

@bfabio bfabio changed the base branch from master to develop June 28, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants