Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Reset button. #117

Open
wants to merge 1 commit into
base: legacy
Choose a base branch
from
Open

Conversation

bfabio
Copy link
Member

@bfabio bfabio commented Nov 17, 2019

Pressing the reset button is the most destructive action the user
can take but, despite that

  • the expected result when pressed is not clear (clear all the fields
    in the current tab? Remove the current tab? Clear all the tabs? Remove
    all the tabs?)
  • it doesn't ask for confirmation
  • it's incredibly prominent (right next to the most used button)

Removing the language tabs can still be achieved more intuitively
by pressing the tab's close button.

Pressing the reset button is the most destructive action the user
can take but, despite that

* the expected result when pressed is not clear (clear all the fields
  in the current tab? Remove the current tab? Clear all the tabs? Remove
  all the tabs?)
* it doesn't ask for confirmation
* it's incredibly prominent (right next to the most used button)

Removing the language tabs can still be achieved more intuitively
by pressing the tab's close button.
@sebbalex
Copy link
Member

Agree this point of view, actually it adds only confusion, it is not clear what is the real purpose and it is too close to the Generate button.
@libremente what do you think?

@libremente
Copy link
Member

I'd start by inserting a message asking for confirmation when the Reset button is pressed. We can have a similar message to the one displayed when the X next to the language tab is clicked. I would not remove it for now.

@sebbalex
Copy link
Member

sebbalex commented Jun 5, 2020

@libremente we need to address this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants