Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Use the Airbnb Style Guide with eslint. #119

Open
wants to merge 1 commit into
base: legacy
Choose a base branch
from

Conversation

bfabio
Copy link
Member

@bfabio bfabio commented Nov 17, 2019

This is a proposal to use the Airbnb Style Guide. IMHO it's the one making most sense, it's well maintained and documented, provides rules for React and it's very comprehensive.

Of course I'll provide the patches required to make the existing codebase conform to the style.

@libremente
Copy link
Member

Hi @bfabio and thanks for your contribution. From a general perspective, I agree with you, I like the ABnB style way more than the one used in this project. However, this change will require a set of changes and review which are not a priority at the moment so I'm afraid we have to reschedule a review of this (and the future commits) on a future milestone.

@bfabio
Copy link
Member Author

bfabio commented Nov 18, 2019

@libremente That makes sense, I'll keep the patches on hold. Thanks.

@bfabio
Copy link
Member Author

bfabio commented Jun 28, 2023

@tensor5 wdyt? I'd try and merge this

@tensor5
Copy link
Contributor

tensor5 commented Jun 28, 2023

I don't have a preference on one lining configuration over the another. Just two questions:

  1. I read here that airbnb assumes Babel. Does it work without?
  2. Does it integrates with TypeScript? I found this package from a quick search.

@bfabio
Copy link
Member Author

bfabio commented Jun 28, 2023

@tensor5 good points, I'll look into them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants