Update ultralytics models #592

dreadatour · 2024-11-13T15:57:27Z

Update Ultralytics YOLO models to be used in SaaS.

This adds Segments model and common YoloBBox, YoloBBoxes, YoloPose, YoloPoses, YoloSegment and YoloSegments models to be used to parse ultralytics results.

cloudflare-workers-and-pages · 2024-11-13T15:58:07Z

Deploying datachain-documentation with Cloudflare Pages

Latest commit:	`530c14c`
Status:	✅ Deploy successful!
Preview URL:	https://ce7ae4cd.datachain-documentation.pages.dev
Branch Preview URL:	https://models-ultralytics.datachain-documentation.pages.dev

View logs

codecov · 2024-11-15T15:13:27Z

Codecov Report

Attention: Patch coverage is 69.96337% with 82 lines in your changes missing coverage. Please review.

Project coverage is 87.41%. Comparing base (059241a) to head (530c14c).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/datachain/lib/models/ultralytics/bbox.py	50.00%	42 Missing ⚠️
src/datachain/lib/models/ultralytics/segment.py	54.00%	23 Missing ⚠️
src/datachain/lib/models/ultralytics/pose.py	69.64%	17 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   87.88%   87.41%   -0.48%     
==========================================
  Files         100      106       +6     
  Lines       10011    10279     +268     
  Branches     1357     1377      +20     
==========================================
+ Hits         8798     8985     +187     
- Misses        871      953      +82     
+ Partials      342      341       -1

Flag	Coverage Δ
datachain	`87.35% <69.96%> (-0.48%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/datachain/lib/models/segment.py

Co-authored-by: Helio Machado <[email protected]>

for more information, see https://pre-commit.ci

0x2b3bfa0

For consistency with ab74442

src/datachain/lib/models/bbox.py

src/datachain/lib/models/pose.py

Co-authored-by: Helio Machado <[email protected]>

for more information, see https://pre-commit.ci

Co-authored-by: Helio Machado <[email protected]>

for more information, see https://pre-commit.ci

dreadatour · 2024-11-17T02:56:04Z

Codecov Report

Attention: Patch coverage is 69.96337% with 82 lines in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (059241a) to head (530c14c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/lib/models/ultralytics/bbox.py 50.00% 42 Missing ⚠️
src/datachain/lib/models/ultralytics/segment.py 54.00% 23 Missing ⚠️
src/datachain/lib/models/ultralytics/pose.py 69.64% 17 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

To be honest I am not sure if it worth it now to implement tests for these files. It will require ultralytics to be installed and models to be downloaded and will affect test execution time.

I think better idea is to add these models usage into examples?

Also we may want to move these models into datachain.tools may be?

mattseddon · 2024-11-17T23:35:09Z

src/datachain/lib/models/ultralytics/segment.py

+        name (list[str]): The names of the segments.
+        confidence (list[float]): The confidences of the segments.
+        box (list[BBox]): The bounding boxes of the segments.
+        segments (list[Segments]): The segments of the segments.


this hurts my brain

What are the options?

This reverts commit b62d091.

dreadatour self-assigned this Nov 13, 2024

dreadatour marked this pull request as draft November 13, 2024 15:57

dreadatour force-pushed the models-ultralytics branch from 628902d to 97483af Compare November 14, 2024 08:51

Update ultralytics models

7c472a6

dreadatour force-pushed the models-ultralytics branch 2 times, most recently from 434d4ce to 884c086 Compare November 15, 2024 15:06

dreadatour force-pushed the models-ultralytics branch from 884c086 to 525624e Compare November 15, 2024 15:13

Simplify ultralytics models

5e7451f

dreadatour force-pushed the models-ultralytics branch from 525624e to 5e7451f Compare November 15, 2024 15:17

dreadatour requested a review from a team November 15, 2024 15:43

dreadatour marked this pull request as ready for review November 15, 2024 15:44

0x2b3bfa0 approved these changes Nov 16, 2024

View reviewed changes

src/datachain/lib/models/segment.py Outdated Show resolved Hide resolved

dreadatour and others added 2 commits November 16, 2024 09:16

Update src/datachain/lib/models/segment.py

ab74442

Co-authored-by: Helio Machado <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

19c0794

for more information, see https://pre-commit.ci

0x2b3bfa0 reviewed Nov 16, 2024

View reviewed changes

src/datachain/lib/models/bbox.py Outdated Show resolved Hide resolved

src/datachain/lib/models/bbox.py Outdated Show resolved Hide resolved

src/datachain/lib/models/pose.py Outdated Show resolved Hide resolved

src/datachain/lib/models/pose.py Outdated Show resolved Hide resolved

dreadatour and others added 7 commits November 17, 2024 09:43

Update src/datachain/lib/models/bbox.py

01df1d5

Co-authored-by: Helio Machado <[email protected]>

Update src/datachain/lib/models/bbox.py

3f29595

Co-authored-by: Helio Machado <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

1ed506d

for more information, see https://pre-commit.ci

Update src/datachain/lib/models/pose.py

99d7f20

Co-authored-by: Helio Machado <[email protected]>

Update src/datachain/lib/models/pose.py

b765678

Co-authored-by: Helio Machado <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

561046e

for more information, see https://pre-commit.ci

[pre-commit.ci] auto fixes from pre-commit.com hooks

530c14c

for more information, see https://pre-commit.ci

dreadatour merged commit b62d091 into main Nov 17, 2024
37 of 38 checks passed

dreadatour deleted the models-ultralytics branch November 17, 2024 03:21

mattseddon reviewed Nov 17, 2024

View reviewed changes

shcheklein added a commit that referenced this pull request Nov 19, 2024

Revert "Update ultralytics models (#592)"

49f2168

This reverts commit b62d091.

shcheklein mentioned this pull request Nov 19, 2024

Revert "Update ultralytics models" #610

Merged

shcheklein added a commit that referenced this pull request Nov 19, 2024

Revert "Update ultralytics models (#592)" (#610)

976b5fd

This reverts commit b62d091.

dreadatour restored the models-ultralytics branch November 20, 2024 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ultralytics models #592

Update ultralytics models #592

dreadatour commented Nov 13, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 13, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

0x2b3bfa0 left a comment

dreadatour commented Nov 17, 2024 •

edited

Loading

Codecov Report

mattseddon Nov 17, 2024

dreadatour Nov 18, 2024

Update ultralytics models #592

Update ultralytics models #592

Conversation

dreadatour commented Nov 13, 2024 • edited Loading

cloudflare-workers-and-pages bot commented Nov 13, 2024 • edited Loading

Deploying datachain-documentation with Cloudflare Pages

codecov bot commented Nov 15, 2024 • edited Loading

Codecov Report

0x2b3bfa0 left a comment

Choose a reason for hiding this comment

dreadatour commented Nov 17, 2024 • edited Loading

Codecov Report

mattseddon Nov 17, 2024

Choose a reason for hiding this comment

dreadatour Nov 18, 2024

Choose a reason for hiding this comment

dreadatour commented Nov 13, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Nov 13, 2024 •

edited

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

dreadatour commented Nov 17, 2024 •

edited

Loading