-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added isnone()
function
#801
Open
ilongin
wants to merge
18
commits into
main
Choose a base branch
from
ilongin/800-isnone-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+200
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 128 128
Lines 11368 11384 +16
Branches 1545 1549 +4
=======================================
+ Hits 9941 9955 +14
- Misses 1038 1039 +1
- Partials 389 390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shcheklein
reviewed
Jan 7, 2025
shcheklein
reviewed
Jan 7, 2025
shcheklein
reviewed
Jan 7, 2025
Deploying datachain-documentation with Cloudflare Pages
|
ilongin
requested review from
shcheklein,
dreadatour,
amritghimire,
mattseddon and
skshetry
January 10, 2025 11:15
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 10, 2025
shcheklein
reviewed
Jan 11, 2025
shcheklein
reviewed
Jan 11, 2025
shcheklein
reviewed
Jan 11, 2025
…tachain into ilongin/800-isnone-function
shcheklein
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isnone(...)
function returnsTrue
if column or literal value isNone
/NULL
, otherwiseFalse
Note that this doesn't currently work for Clickhouse where we don't have nullable columns. We should decide if we want to introduce nullable columns and if yes, this will work there as well.
UPDATE:
In addition, this PR extends
case()
function and related codebase to accept nested functions in:else_
valueThis will allow usage of functions inside other functions that are based on case like
ifelse
orisnone
as well. We also will have ability to do nested cases etc.