Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): disable bucket cache if region or endpoint are specified #809

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

shcheklein
Copy link
Member

Until (or similar fix) lands fsspec/s3fs#929 we need to do this check to make DataChain work with custom endpoints provided via env vars (e.g. in Studio).

@shcheklein shcheklein requested a review from a team January 11, 2025 19:46
Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4634a13
Status: ✅  Deploy successful!
Preview URL: https://e0d2f1fa.datachain-documentation.pages.dev
Branch Preview URL: https://fix-client-disable-bucket-ca.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.44%. Comparing base (2364ac2) to head (4634a13).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/client/s3.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   87.44%   87.44%   -0.01%     
==========================================
  Files         128      128              
  Lines       11369    11371       +2     
  Branches     1535     1536       +1     
==========================================
+ Hits         9942     9943       +1     
  Misses       1048     1048              
- Partials      379      380       +1     
Flag Coverage Δ
datachain 87.38% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shcheklein shcheklein merged commit b3a060d into main Jan 12, 2025
37 of 38 checks passed
@shcheklein shcheklein deleted the fix-client-disable-bucket-cache branch January 12, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants