Removing SQLAlchemy from DataChain.compare()
#881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
edc6696
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bdee409a.datachain-documentation.pages.dev |
| Branch Preview URL: | https://ilongin-721-compare-remove-s.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 87.73% 87.70% -0.04%
==========================================
Files 129 129
Lines 11483 11464 -19
Branches 1547 1546 -1
==========================================
- Hits 10075 10054 -21
- Misses 1020 1021 +1
- Partials 388 389 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ilongin
requested review from
mattseddon,
dreadatour,
amritghimire and
skshetry
dreadatour
approved these changes
Feb 4, 2025
src/datachain/diff/__init__.py
Outdated
| @@ -44,66 +44,49 @@ def _compare( # noqa: PLR0912, PLR0915, C901 | |||
| modified: bool = True, | |||
| same: bool = True, | |||
| status_col: Optional[str] = None, | |||
| ) -> "DataChain": | |||
| ): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing SQLAlchemy constructs from
compare()function.TODO:
or_when Adding explicitor_function #894 is done