Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(referencefs): override _open only for fsspec<2025.2.0 #884

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Feb 2, 2025

Following changes from fsspec/filesystem_spec#1778.

Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e36956
Status: ✅  Deploy successful!
Preview URL: https://7e13d720.datachain-documentation.pages.dev
Branch Preview URL: https://fsspec-2025-2-0.datachain-documentation.pages.dev

View logs

@skshetry skshetry changed the title refactor(referencefs): only override ReferenceFileSystem._open for fsspec<2025.2.0 refactor(referencefs): override _open only for fsspec<2025.2.0 Feb 2, 2025
@skshetry skshetry changed the title refactor(referencefs): override _open only for fsspec<2025.2.0 refactor(referencefs): override _open only for fsspec<2025.2.0 Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (143b4be) to head (8e36956).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/fs/reference.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
- Coverage   87.65%   87.64%   -0.02%     
==========================================
  Files         128      129       +1     
  Lines       11457    11463       +6     
  Branches     1544     1545       +1     
==========================================
+ Hits        10043    10047       +4     
- Misses       1026     1027       +1     
- Partials      388      389       +1     
Flag Coverage Δ
datachain 87.56% <84.61%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry requested a review from a team February 2, 2025 04:39
@skshetry skshetry merged commit 0eed18f into main Feb 3, 2025
36 of 37 checks passed
@skshetry skshetry deleted the fsspec-2025.2.0 branch February 3, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants