Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasets filter for datachain ds ls #898

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

amritghimire
Copy link
Contributor

With this change, a optional positional arg is added for datachain ds
ls.

Example output:

datachain ds ls temp
Name    Studio    Local
------  --------  -------
temp    v1        ✖
temp    v2        ✖
temp    v3        ✖
temp    v4        ✖
temp    v5        ✖
temp    v6        ✖
temp    v7        ✖
temp    v8        ✖
temp    v9        ✖
temp    v10       ✖
temp    v11       ✖
temp    v12       ✖
temp    v13       v13

With this change, a optional positional arg is added for datachain ds
ls.

Example output:
```
datachain ds ls temp
Name    Studio    Local
------  --------  -------
temp    v1        ✖
temp    v2        ✖
temp    v3        ✖
temp    v4        ✖
temp    v5        ✖
temp    v6        ✖
temp    v7        ✖
temp    v8        ✖
temp    v9        ✖
temp    v10       ✖
temp    v11       ✖
temp    v12       ✖
temp    v13       v13
```
@amritghimire amritghimire self-assigned this Feb 5, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0952dcb
Status: ✅  Deploy successful!
Preview URL: https://366969e7.datachain-documentation.pages.dev
Branch Preview URL: https://amrit-ls-dataset-filter.datachain-documentation.pages.dev

View logs

@amritghimire amritghimire requested review from ilongin, dreadatour and a team February 5, 2025 16:09
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (d0c5f94) to head (0952dcb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/cli/commands/datasets.py 58.82% 6 Missing and 1 partial ⚠️
src/datachain/studio.py 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   87.67%   87.64%   -0.03%     
==========================================
  Files         129      129              
  Lines       11490    11513      +23     
  Branches     1553     1560       +7     
==========================================
+ Hits        10074    10091      +17     
- Misses       1025     1030       +5     
- Partials      391      392       +1     
Flag Coverage Δ
datachain 87.57% <65.62%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shcheklein
Copy link
Member

@amritghimire could you please add the exact command that you run?

@amritghimire
Copy link
Contributor Author

@amritghimire could you please add the exact command that you run?

It is in PR description.

datachain ds ls temp

where temp is the name of dataset.

@amritghimire amritghimire merged commit 79f6cf9 into main Feb 7, 2025
36 of 37 checks passed
@amritghimire amritghimire deleted the amrit/ls-dataset-filter branch February 7, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants