Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add periodic broadcaster #107

Merged
merged 4 commits into from
Dec 2, 2024
Merged

feat: add periodic broadcaster #107

merged 4 commits into from
Dec 2, 2024

Conversation

joshieDo
Copy link
Contributor

@joshieDo joshieDo commented Nov 28, 2024 •
edited
Loading

closes #103

Adds a service that every 10 minutes re-broadcasts transactions belonging to the sponsor from the txpool

@joshieDo joshieDo added C-enhancement New feature or request A-node labels Nov 28, 2024
@joshieDo joshieDo changed the title add periodic broadcaster feat: add periodic broadcaster Nov 28, 2024
mattsse
mattsse requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually pretty simple,

smol nits

bin/odyssey/src/main.rs Outdated Show resolved Hide resolved
crates/node/src/broadcaster.rs Outdated Show resolved Hide resolved
@joshieDo joshieDo requested a review from mattsse November 29, 2024 13:30
mattsse
mattsse approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, doc nits

bin/odyssey/src/main.rs Show resolved Hide resolved
@mattsse mattsse merged commit 482f454 into main Dec 2, 2024
14 checks passed
@mattsse mattsse deleted the joshie/broadcaster branch December 2, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-node C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add periodic tx broadcaster
2 participants
@joshieDo @mattsse