test: basic tx validation tests #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
onbjerg/validation-tests
branch
from
2ed1d5b to
7a6fc36
Compare
mattsse
approved these changes
Oct 12, 2024
crates/wallet/src/lib.rs
Outdated
| @@ -386,4 +386,45 @@ mod tests { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| mod validation { | |||
There was a problem hiding this comment.
nit: we should get rid of nested mods in tests mod, this is just bloat -.-
There was a problem hiding this comment.
imo it makes test output way more readable, but can remove
onbjerg
force-pushed
the
onbjerg/validation-tests
branch
from
7a6fc36 to
ce8a245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some basic tests for
validate_tx_request