feat(kona-exex): basic exex setup & routing #12
Conversation
bin/kona-exex/src/main.rs
Outdated
| Cli::<KonaArgsExt>::parse().run(|builder, args| async move { | ||
| let node = EthereumNode::default(); |
There was a problem hiding this comment.
qq: should we try to init the ROLLUP_CONFIG here or is it better to panic! inside KonaExEx::new?
There was a problem hiding this comment.
probably better to do rollup config init here if it's fallible, unless you expect new to also be fallible, since run returns a Result
There was a problem hiding this comment.
for now we don't expect new() to be fallible, ty!
There was a problem hiding this comment.
I think @Rjected meant the rollup config initialization is fallible - which it should be in your draft.
let Some(cfg) = ROLLUP_CONFIGS.get(&args.l2_chain_id).cloned().map(Arc::new) else {
bail!("Rollup configuration not found for L2 chain id: {}", args.l2_chain_id);
};Since ROLLUP_CONFIGS is a hashmap in the superchain-registry, the kv pair may not exist so this becomes fallible right
There was a problem hiding this comment.
@refcell not sure I follow - if the config doesn't exist for the specified chain id we should exit the exex, correct?
merklefruit
force-pushed
the
nico/feat/basic-exex-setup
branch
from
0518bb1 to
bb75457
Compare
|
|
||
| fn main() -> Result<()> { | ||
| Cli::<KonaArgsExt>::parse().run(|builder, args| async move { | ||
| let Some(cfg) = ROLLUP_CONFIGS.get(&args.l2_chain_id).cloned() else { |
There was a problem hiding this comment.
in the future would it be worth allowing rollup configs outside of the registry using a cli param or file (maybe for ephemeral devnets or something)? if so would make an issue for it
There was a problem hiding this comment.
I think so, for stuff like kurtosis specifying a path to a TOML file should be a good idea.
This should live inside the superchain-primitives crate imo, if it makes sense i'll open an issue, cc @refcell
shekhirin
added
C-enhancement
closes #3