feat: split reth and hera binaries
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
force-pushed
the
nico/feat/split-bins
branch
from
29f0c4c to
56b9044
Compare
merklefruit
force-pushed
the
nico/feat/split-bins
branch
from
56b9044 to
da662e5
Compare
refcell
reviewed
Aug 24, 2024
refcell
reviewed
Aug 24, 2024
refcell
requested changes
Aug 24, 2024
Rjected
reviewed
Aug 24, 2024
chore: typo chore: rm useless clippy rules chore: small type coercion fix: commit tip before breaking loop feat(hera): rebased on bin/ location change chore: rename kona -> hera in cli
merklefruit
force-pushed
the
nico/feat/split-bins
branch
from
243f0ec to
e3f9354
Compare
This was referenced Aug 25, 2024
merklefruit
added a commit
to merklefruit/op-rs
that referenced
this pull request
Aug 25, 2024
Followup from ithacaxyz#14 Many ways to do this, but for now here's what we have: - the `reth` binary runs the default reth CLI commands with an optional `--hera` flag. If set, we also try to parse all `HeraArgsExt` flags and install the ExEx on top of it. The idea is that in the future we may have more ExExes that can be added in this way. - `hera` binary is currently empty, but will contain the standalone rollup node entrypoint. - refactored `hera-exex` to its own crate, this will make it possible to also run hera as exex from the `hera` binary as well. Note: there is a compilation error due to op-rs/kona#454, unrelated to this pr. Open to feedback feat(kona-exex): step 1: wait for l2 genesis block chore: typo chore: rm useless clippy rules chore: small type coercion fix: commit tip before breaking loop feat(hera): rebased on bin/ location change chore: rename kona -> hera in cli feat: split reth and hera binaries chore: cargo lock fix: last compile err chore: add crate lints feat: renamed bin, renamed driver, addressed pr review chore: fmt feat: optionally load rollup config from file
merklefruit
added a commit
to merklefruit/op-rs
that referenced
this pull request
Aug 25, 2024
Followup from ithacaxyz#14 Many ways to do this, but for now here's what we have: - the `reth` binary runs the default reth CLI commands with an optional `--hera` flag. If set, we also try to parse all `HeraArgsExt` flags and install the ExEx on top of it. The idea is that in the future we may have more ExExes that can be added in this way. - `hera` binary is currently empty, but will contain the standalone rollup node entrypoint. - refactored `hera-exex` to its own crate, this will make it possible to also run hera as exex from the `hera` binary as well. Note: there is a compilation error due to op-rs/kona#454, unrelated to this pr. Open to feedback feat(kona-exex): step 1: wait for l2 genesis block chore: typo chore: rm useless clippy rules chore: small type coercion fix: commit tip before breaking loop feat(hera): rebased on bin/ location change chore: rename kona -> hera in cli feat: split reth and hera binaries chore: cargo lock fix: last compile err chore: add crate lints feat: renamed bin, renamed driver, addressed pr review chore: fmt feat: optionally load rollup config from file
merklefruit
added a commit
to merklefruit/op-rs
that referenced
this pull request
Aug 25, 2024
Followup from ithacaxyz#14 Many ways to do this, but for now here's what we have: - the `reth` binary runs the default reth CLI commands with an optional `--hera` flag. If set, we also try to parse all `HeraArgsExt` flags and install the ExEx on top of it. The idea is that in the future we may have more ExExes that can be added in this way. - `hera` binary is currently empty, but will contain the standalone rollup node entrypoint. - refactored `hera-exex` to its own crate, this will make it possible to also run hera as exex from the `hera` binary as well. Note: there is a compilation error due to op-rs/kona#454, unrelated to this pr. Open to feedback feat(kona-exex): step 1: wait for l2 genesis block chore: typo chore: rm useless clippy rules chore: small type coercion fix: commit tip before breaking loop feat(hera): rebased on bin/ location change chore: rename kona -> hera in cli feat: split reth and hera binaries chore: cargo lock fix: last compile err chore: add crate lints feat: renamed bin, renamed driver, addressed pr review chore: fmt feat: optionally load rollup config from file chore: rebase chore: rebase chore: rebase
shekhirin
added
A-hera
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #14
Many ways to do this, but for now here's what we have:
rethbinary runs the default reth CLI commands with an optional--heraflag. If set, we also try to parse allHeraArgsExtflags and install the ExEx on top of it. The idea is that in the future we may have more ExExes that can be added in this way.herabinary is currently empty, but will contain the standalone rollup node entrypoint.hera-exexto its own crate, this will make it possible to also run hera as exex from theherabinary as well.Note: there is a compilation error due to op-rs/kona#454, unrelated to this pr.
Open to feedback