Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hera): Run the Network Driver #44

Merged
merged 10 commits into from
Aug 29, 2024
Merged

feat(hera): Run the Network Driver #44

merged 10 commits into from
Aug 29, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 27, 2024

Description

Runs the NetworkDriver in the hera binary.

Think the op stack enr data isn't being deserialized correctly. Ether's rlp decoding uses an RlpStream which I'm not sure is the same way alloy_rlp decodes.

@refcell refcell requested a review from merklefruit August 27, 2024 02:57
@refcell refcell self-assigned this Aug 27, 2024
@refcell refcell added the A-hera Area: OP Stack Rollup node binary label Aug 27, 2024
@refcell refcell requested a review from Rjected August 27, 2024 17:35
merklefruit
merklefruit reviewed Aug 27, 2024
View reviewed changes
bin/hera/src/main.rs Outdated Show resolved Hide resolved
@refcell refcell marked this pull request as draft August 27, 2024 19:18
@refcell refcell marked this pull request as ready for review August 28, 2024 23:00
@merklefruit
fix(net): bind on unspecified socket (#60)
48e89b5 
binds the network driver to 0.0.0.0 instead of the loopback interface.
@refcell refcell requested a review from merklefruit August 29, 2024 19:06
@refcell refcell requested a review from merklefruit August 29, 2024 20:45
merklefruit
merklefruit approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@refcell refcell merged commit 28258e6 into main Aug 29, 2024
11 checks passed
@refcell refcell deleted the rf/feat/run-network-driver branch August 29, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

@Rjected Rjected Awaiting requested review from Rjected

Assignees

@refcell refcell

Labels
A-hera Area: OP Stack Rollup node binary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @merklefruit