Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net): Allow custom noise configuration #46

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix(net): Allow custom noise configuration #46

merged 2 commits into from
Aug 27, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 27, 2024

Description

Allows the use to specify the libp2p::noise::Config on the Network.

@refcell refcell requested a review from merklefruit August 27, 2024 14:14
@refcell refcell self-assigned this Aug 27, 2024
@refcell refcell added the A-net Area: Network crate label Aug 27, 2024
@refcell refcell mentioned this pull request Aug 27, 2024
Merged
@refcell refcell requested a review from Rjected August 27, 2024 15:29
@refcell refcell requested a review from merklefruit August 27, 2024 16:09
merklefruit
merklefruit approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@refcell refcell merged commit 6076e93 into main Aug 27, 2024
11 checks passed
@refcell refcell deleted the rf/fix/expose-noise-config branch August 27, 2024 16:10
refcell added a commit that referenced this pull request Aug 27, 2024
@refcell
feat(net): Refactor GossipDriver (#47)
a8d2c32 
### Description

> [!WARNING]
>
> Stacked ontop of #46, merge after #46.

Refactors `GossipDriver` specific logic out of the top-level
`NetworkDriver` and into the `GossipDriver`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

@Rjected Rjected Awaiting requested review from Rjected

Assignees

@refcell refcell

Labels
A-net Area: Network crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @merklefruit