Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(net): Remove NetworkAddress #55

Merged
merged 2 commits into from
Aug 28, 2024
Merged

feat(net): Remove NetworkAddress #55

merged 2 commits into from
Aug 28, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 28, 2024

Description

Removes the NetworkAddress which is effectively used as a conversion utility between the SocketAddr and MulitAddr.

Closes #52

@refcell refcell self-assigned this Aug 28, 2024
@refcell refcell requested a review from merklefruit August 28, 2024 14:51
@refcell refcell added the A-net Area: Network crate label Aug 28, 2024
@refcell refcell mentioned this pull request Aug 28, 2024
Merged
@refcell refcell requested a review from Rjected August 28, 2024 14:58
merklefruit
merklefruit approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/net/src/builder.rs Outdated Show resolved Hide resolved
@refcell @merklefruit
Update builder.rs
cd360cf 
Co-authored-by: nicolas <[email protected]>
@refcell refcell merged commit 9c08589 into main Aug 28, 2024
11 checks passed
@refcell refcell deleted the rf/feat/remove-network-address branch August 28, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

@Rjected Rjected Awaiting requested review from Rjected

Assignees

@refcell refcell

Labels
A-net Area: Network crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(net): Remove NetworkAddress
2 participants
@refcell @merklefruit