Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(net): Peer Arbitrary and Testing #67

Merged
merged 3 commits into from
Aug 30, 2024
Merged

feat(net): Peer Arbitrary and Testing #67

merged 3 commits into from
Aug 30, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 30, 2024

Description

Warning

This PR is stacked ontop of #66.

  • Adds Arbitrary support to the Peer type.
  • Adds unit and prop testing for Peer type conversions.

@refcell refcell added C-enhancement New feature or request A-net Area: Network crate D-do-not-merge Desc: Do not merge labels Aug 30, 2024
@refcell refcell self-assigned this Aug 30, 2024
@refcell refcell requested a review from merklefruit August 30, 2024 13:31
@refcell refcell added the D-stacked Desc: Stacked ontop of another PR label Aug 30, 2024
@refcell refcell mentioned this pull request Aug 30, 2024
Closed
merklefruit
merklefruit approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/net/src/types/enr.rs Outdated Show resolved Hide resolved
@refcell refcell merged commit a63e429 into main Aug 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

Assignees

@refcell refcell

Labels
A-net Area: Network crate C-enhancement New feature or request D-do-not-merge Desc: Do not merge D-stacked Desc: Stacked ontop of another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @merklefruit